Conversation
# Conflicts: # mothernet/evaluation/plot_shape_function.py
|
@amueller I merged your changes and fixed the column labeling. |
|
Hm it feels strange that we make up a bin on the left but not the right. Shouldn't we have to make up a bin on both sides? Maybe you need to make up a bin on the end and duplicate the last weight to get the correct plot? Cause otherwise the last step has a bin of width 0 associated with it? |
|
an alternative might be to use |
|
I understand that it isn't the cleanest fix, but I think for the paper we will want to use probably the shape function plotting from the EBM repo? Maybe this is sufficient for the plots we are doing right now? |
|
@JulienSiems I don't think @Harsha-Nori will have time to do the integration with the EBM vis, I'm not sure if either of us will be able to do it? |
|
Hey! I'm unfortunately summoned on travel again, but I pushed some WIP code for shape function plotting using |
No description provided.