Skip to content
This repository was archived by the owner on Jun 11, 2020. It is now read-only.

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey
Copy link
Contributor Author

Ping @sandersn @RyanCavanaugh

@orta
Copy link
Contributor

orta commented Sep 20, 2019

Looks good to me - I wonder if all of the packages will need to go in eventually. However right now this should be fine.

@orta orta merged commit f0f55bc into microsoft:master Sep 20, 2019
@MichaelDeBoey
Copy link
Contributor Author

If so, I'll add a new PR for them 🙂

@MichaelDeBoey
Copy link
Contributor Author

@orta I still get the error that @storybook/react isn't whitelisted.

Something I should do for that? 🤔

@orta
Copy link
Contributor

orta commented Sep 21, 2019

Yeah, looks like making changes is a multi-step process, one of those steps is deploying a new version of this module - just waiting on #659

@MichaelDeBoey
Copy link
Contributor Author

@orta Can you deploy manually now so I can keep working on DefinitelyTyped/DefinitelyTyped#38447 please? 🤔

@orta
Copy link
Contributor

orta commented Sep 21, 2019

Nope, sorry - I don't have access to that NPM module

@MichaelDeBoey
Copy link
Contributor Author

Too bad 😕

Hopefully @sandersn or @RyanCavanaugh can make this happen quickly 🙂

@sandersn
Copy link
Member

Deployment of types-publisher is not standard, but I think it only needs membership on the microsoft-internal typescript team. I went ahead and deployed it for now, and we can talk about reworking the deployment on #659.

Anyway, @storybook/react is now in the production branch, so Definitely Typed's CI will get the new whitelist next time it runs.

@MichaelDeBoey
Copy link
Contributor Author

Thanks @sandersn! 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants