Skip to content

Bump TCGC to 0.67.1 for http-client-csharp#10309

Open
Copilot wants to merge 18 commits intomainfrom
copilot/bump-tcgc-to-0-67-0
Open

Bump TCGC to 0.67.1 for http-client-csharp#10309
Copilot wants to merge 18 commits intomainfrom
copilot/bump-tcgc-to-0-67-0

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 8, 2026

Bump @azure-tools/typespec-client-generator-core from 0.66.3 to 0.67.1 and all related dependencies for the http-client-csharp emitter.

Dependency bumps

  • TCGC: 0.66.3 → 0.67.1, Azure Core: 0.66.0 → 0.67.0
  • @typespec/compiler, http, openapi: 1.10.0 → 1.11.0
  • @typespec/rest, sse, streams, versioning, xml, json-schema, library-linter: 0.80.0 → 0.81.0
  • http-specs, azure-http-specs, spector: bumped to latest compatible alphas
  • Peer dependency ranges updated accordingly

Breaking change fixes

  • utils.ts__raw.service renamed to __raw.services (now always Namespace[]):
    // before
    return Array.isArray(client.__raw.service) && client.__raw.service.length > 1;
    // after
    return client.__raw.services.length > 1;
  • type-converter.ts — Guard sdkType.__raw before calling getAccessOverride(). Synthetic enums (content-type/accept params) created by TCGC 0.67.0 have __raw === undefined.

Test updates

  • Multi-service tests now use autoMergeService: true on @client (required in 0.67.0 for sub-client merging across services)
  • Removed @useDependency from multi-service tests (no longer used for API version declaration per migration guide)

Regenerated test libraries

Regenerated all Spector specs, Sample-TypeSpec (Local), and launch settings via Generate.ps1. No changes to Generate.ps1 or SampleService/package.json. Expected code model diffs: doc string updates removing @operationGroup references, fully-qualified crossLanguageDefinitionId paths, synthetic enums for content-type/accept parameters, improved constant naming.

Copilot AI linked an issue Apr 8, 2026 that may be closed by this pull request
- Update @azure-tools/typespec-client-generator-core from 0.66.3 to 0.67.0
- Update @azure-tools/typespec-azure-core from 0.66.0 to 0.67.0
- Update @typespec/compiler, http, openapi from 1.10.0 to 1.11.0
- Update @typespec/rest, sse, streams, versioning, xml from 0.80.0 to 0.81.0
- Update peer dependencies to match new version ranges
- Fix __raw.services breaking change (was __raw.service)
- Guard getAccessOverride for synthetic enums without __raw
- Update multi-service tests to use autoMergeService and remove @useDependency

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/9b068e45-e5ee-46b0-8dec-fc0c79650546

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Apr 8, 2026
Code model changes include:
- Doc string updates (removing @operationGroup references)
- crossLanguageDefinitionId now includes full namespace paths
- Better naming for constant types
- Model ordering changes in code model JSON

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/9b068e45-e5ee-46b0-8dec-fc0c79650546

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump TCGC to version 0.67.0 and update dependencies Bump TCGC to 0.67.0 for http-client-csharp Apr 8, 2026
Copilot AI requested a review from jorgerangel-msft April 8, 2026 15:24
Copy link
Copy Markdown
Contributor

@jorgerangel-msft jorgerangel-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot there are CI failures related to the regen checks. Investigate them and also ensure you rerun both Generate.ps1 and Test-Spector.ps1

…r override

- Update SampleService package.json to latest published version (1.0.0-alpha.20260407.1)
- Fix Generate.ps1 to use local emitter for SampleService compilation via --emit flag
- Regenerate all test projects including Sample-TypeSpec and SampleService
- Add newly generated files (ConfigurationSchema.json, Settings files, NuGet targets)

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/9f94861c-2ccb-44cb-ad44-3e6e7238053d

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 8, 2026

@copilot there are CI failures related to the regen checks. Investigate them and also ensure you rerun both Generate.ps1 and Test-Spector.ps1

Investigated and fixed the CI regen failures in commit 3d5aff5. The issues were:

  1. SampleService npm install failure: The published @typespec/http-client-csharp had peer dep conflicts with the bumped TypeSpec deps. Updated SampleService to use 1.0.0-alpha.20260407.1 which has wider peer dep ranges.

  2. SampleService tsp compile crash: The published emitter code has the getAccessOverride bug when run with TCGC 0.67.0 (synthetic enums with __raw === undefined). Fixed Generate.ps1 to pass --emit $packageRoot so the SampleService compilation uses the local emitter build instead of the published version.

  3. Incomplete regeneration: Previously ran Generate.ps1 with a filter which skipped the SampleService, Sample-TypeSpec (Local), and launch settings. Now ran full Generate.ps1 without filter — all test projects are regenerated and committed.

Test-Spector.ps1 was started but takes very long (1hr+). Emitter tests (196 pass) and generator tests (1302 pass) all pass.

…purious README.md

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/1b82cdb2-3c40-4ccf-adc2-308467b343aa

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 8, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@10309

commit: b292c61

…back

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/dfd2e68b-1fe9-4fde-9797-caf864e5be31

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/a645f4e2-c224-4061-a8a9-41b7462d3ce4

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
@JoshLove-msft
Copy link
Copy Markdown
Contributor

@copilot there is now a 0.67.1.

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/ecdb15eb-9720-44ee-af9d-ea506ec886f3

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 9, 2026

@copilot there is now a 0.67.1.

Bumped TCGC from 0.67.0 to 0.67.1 in 3af966d. All 196 emitter tests pass. The peer dep range >=0.67.0 <0.68.0 already covers 0.67.1 so no change needed there.

Copilot AI changed the title Bump TCGC to 0.67.0 for http-client-csharp Bump TCGC to 0.67.1 for http-client-csharp Apr 9, 2026
Copilot AI requested a review from JoshLove-msft April 9, 2026 03:12
@jorgerangel-msft jorgerangel-msft added this pull request to the merge queue Apr 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2026
@jorgerangel-msft jorgerangel-msft added this pull request to the merge queue Apr 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2026
@jorgerangel-msft jorgerangel-msft added this pull request to the merge queue Apr 9, 2026
@jorgerangel-msft jorgerangel-msft removed this pull request from the merge queue due to a manual request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump TCGC to 0.67.1

3 participants