-
Notifications
You must be signed in to change notification settings - Fork 353
[C# Generator] Populate attributes from custom code properties and fields in NamedTypeSymbolProvider #10322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/fix-custom-code-properties-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[C# Generator] Populate attributes from custom code properties and fields in NamedTypeSymbolProvider #10322
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
241e002
Initial plan
Copilot 596a431
fix: populate attributes from IPropertySymbol in NamedTypeSymbolProvi…
Copilot 7afaec5
fix: also populate attributes for fields, improve tests with CSharpTy…
Copilot 259767f
fix: revert CodeGen attribute filtering, add PositionalArguments test…
Copilot 6ee954c
fix: revert expected output change and stop propagating field attribu…
Copilot 421fef1
fix: revert FieldProvider.InitializeParameter to propagate attributes…
Copilot ecf9570
fix: filter codegen attributes from field-to-parameter propagation in…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...delProviders/TestData/ModelCustomizationTests/CanReadPropertyAttributes/MockInputModel.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #nullable disable | ||
|
|
||
| using System; | ||
| using System.ComponentModel; | ||
|
|
||
| namespace Sample.Models | ||
| { | ||
| public class CustomAttribute : Attribute | ||
| { | ||
| public CustomAttribute(string message) { } | ||
| } | ||
|
|
||
| public partial class MockInputModel | ||
| { | ||
| [Obsolete("This property is now deprecated.", DiagnosticId = "OBS001")] | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| [Custom("custom message")] | ||
| public string Prop1 { get; set; } | ||
|
|
||
| [Obsolete("This field is now deprecated.")] | ||
| private int _customField; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.