[http-server-csharp] add arrayDeclarationContext#10327

Draft

sophia-ramsey wants to merge 2 commits intomainfrom

sramsey/csharp-service-arrayDeclarationContext

Member

sophia-ramsey commented Apr 9, 2026

In my work in the openai-openapi-pr repo, the service emitter would not compile and gave the following error message:

Error: Emit context must have a scope set in order to create references to declarations.
    at compilerAssert (asset-emitter.js)
    at invokeReference (asset-emitter.js)
    at CSharpCodeEmitter.collectionDeclaration (service.js)
    at CSharpCodeEmitter.arrayDeclaration (service.js)

I fixed the issue when I added arrayDeclarationContext to the local node_modules in my repo. Here is the fix that I made as well as a test that demonstrates the issue.


          [http-server-csharp] add arrayDeclarationContext

4940d3c

Contributor

github-actions bot commented Apr 9, 2026 •

edited

Loading

All changed packages have been documented.

✅ @typespec/http-server-csharp

Show changes

`@typespec/http-server-csharp` - fix ✏️

add arrayDeclarationContext

Collaborator

azure-sdk commented Apr 9, 2026 •

edited

Loading

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension

timotheeguerin approved these changes

View reviewed changes

timotheeguerin assigned markcowl


          format and chronus

91d3430

pkg-pr-new bot commented Apr 9, 2026 •

edited

Loading

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-server-csharp@10327

commit: 91d3430

sophia-ramsey force-pushed the sramsey/csharp-service-arrayDeclarationContext branch from 215dc6d to 91d3430 Compare

April 9, 2026 20:46

markcowl requested changes

View reviewed changes

Contributor

markcowl left a comment

Thanks for the contribution! A few comments. I think the context is necessary, but the dedicated emitted file is not useful and we should avoid emitting it if possible.

packages/http-server-csharp/test/generation.test.ts

+                      `,
+                    [
+                      [
+                        "Tags.cs",

Contributor

markcowl Apr 9, 2026

Why are we generating a file for this? What do we expect the file to contain? Shouldn't we find a way to not emit the array type (while making sure we emit the item type)?

packages/http-server-csharp/test/generation.test.ts

+                      "My.Custom.Ns",
+                    ],
+                    [
+                      ["Items.cs", ["// Generated by @typespec/http-server-csharp", "using System;"]],

Contributor

markcowl Apr 9, 2026

Same comment

packages/http-server-csharp/test/generation.test.ts

+                          "public string Name { get; set; }",
+                        ],
+                      ],
+                      ["WidgetList.cs", ["// Generated by @typespec/http-server-csharp", "using System;"]],

Contributor

markcowl Apr 9, 2026

Again, this file shouldn't exist

packages/http-server-csharp/test/generation.test.ts

+                      @route("/chat") op chat(): AssistantMessage;
+                      `,
+                    [
+                      ["AssistantMessage.cs", [`public string Role { get; } = "assistant";`]],

Contributor

markcowl Apr 9, 2026

I'd like to test for the rest of the defintion here (I think it should either be an Object or a generic json type

packages/http-server-csharp/test/generation.test.ts

+                        ],
+                      ],
+                      ["WidgetList.cs", ["// Generated by @typespec/http-server-csharp", "using System;"]],
+                      ["IContosoOperations.cs", ["Task<Widget[]> GetWidgetsAsync( )"]],

Contributor

markcowl Apr 9, 2026

Here we should make sure there is an appropriate using for the namespace containing Widget

packages/http-server-csharp/src/lib/service.ts

+                  arrayDeclarationContext(array: Model, name: string, elementType: Type) {
+                    const arrayName = ensureCSharpIdentifier(this.emitter.getProgram(), array, name);
+                    const arrayFile = this.emitter.createSourceFile(`generated/models/${arrayName}.cs`);
+                    arrayFile.meta[this.#sourceTypeKey] = CSharpSourceType.Model;

Contributor

markcowl Apr 9, 2026

We could potentially use this to not emit the useless array model. Ideally, we could create a context without an emitted file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markcowl markcowl requested changes

timotheeguerin timotheeguerin approved these changes

bterlson Awaiting requested review from bterlson bterlson will be requested when the pull request is marked ready for review bterlson is a code owner

witemple-msft Awaiting requested review from witemple-msft witemple-msft will be requested when the pull request is marked ready for review witemple-msft is a code owner

chrisradek Awaiting requested review from chrisradek chrisradek will be requested when the pull request is marked ready for review chrisradek is a code owner

AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez will be requested when the pull request is marked ready for review AlitzelMendez is a code owner

Requested changes must be addressed to merge this pull request.

Labels

None yet