Fix the base type issue of models#3730

Merged

m-nash merged 58 commits intomicrosoft:mainfrom

ArcturusZhang:fix-base-type-issue

Jul 17, 2024

Member

ArcturusZhang commented Jul 2, 2024 •

edited

Loading

Fixes #3729
Fixes #3741

ArcturusZhang added 3 commits

July 2, 2024 14:53


          remove the link temporarily

b7a391a


          add a step to build the test project

8180b12


          fix the base type issue

9d534d8

ArcturusZhang requested review from JoshLove-msft and m-nash as code owners

July 2, 2024 07:38

microsoft-github-policy-service bot added the emitter:client:csharp label


          fix issues

f1b692d

Collaborator

azure-sdk commented Jul 2, 2024

API change check

API changes are not detected in this pull request.

jorgerangel-msft approved these changes

View reviewed changes

ArcturusZhang added 3 commits

July 3, 2024 10:19


          Merge branch 'main' into fix-base-type-issue

ec92093


          Merge branch 'main' into remove-the-link-to-make-the-project-build

2afcc7b


          update the base ctor

3504d18

m-nash approved these changes

View reviewed changes


          fix the deserialization static method issue

ca1e5b9

ArcturusZhang commented

View reviewed changes

...s/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/ParameterProvider.cs Outdated Show resolved Hide resolved

ArcturusZhang added 7 commits

July 3, 2024 14:58


          refactor

942f936


          fix typo

65ebb99


          add the link back

a649a22


          fix typo

a9a84f7


          Merge remote-tracking branch 'forked/remove-the-link-to-make-the-proj…

f79423c

…ect-build' into fix-base-type-issue


          fix the return type issue


          fix test cases

e1edc70

jorgerangel-msft reviewed

View reviewed changes

...nerator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeProvider.cs Outdated Show resolved Hide resolved

ArcturusZhang added 5 commits

July 4, 2024 07:21


          Merge remote-tracking branch 'origin/main' into fix-base-type-issue

b38bf1f


          fix after merge

47ee984


          overhauls the test cases for mrw serialization

3b44a4b


          refine

0d53c60


          Merge branch 'main' into fix-base-type-issue

b21a84b

live1206 reviewed

View reviewed changes

...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs Outdated Show resolved Hide resolved

...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs Outdated Show resolved Hide resolved

...osoft.Generator.CSharp.Input/src/InputTypes/Serialization/TypeSpecInputModelTypeConverter.cs Show resolved Hide resolved

packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/ModelProvider.cs Outdated Show resolved Hide resolved

packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Shared/StringExtensions.cs Outdated Show resolved Hide resolved


          Merge remote-tracking branch 'origin/main' into fix-base-type-issue

2e3caa4

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel
Microsoft.Generator.CSharp.Input


          fix test cases

ed3cbfd

ArcturusZhang requested a review from m-nash

July 17, 2024 09:33


          fix issues in ClientModelPlugin

89533b8

ArcturusZhang commented

View reviewed changes

...http-client-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/ClientModelPlugin.cs Outdated Show resolved Hide resolved

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel
Microsoft.Generator.CSharp.Input

ArcturusZhang added 2 commits

July 17, 2024 22:21


          change the test cases

6b4a86f


          resolve the last comment

83d7967

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel
Microsoft.Generator.CSharp.Input


          updates

38f5dbb

m-nash approved these changes

View reviewed changes

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel
Microsoft.Generator.CSharp.Input


          fix format

2e40229

m-nash enabled auto-merge

July 17, 2024 20:24

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel

Collaborator

azure-sdk commented Jul 17, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel
Microsoft.Generator.CSharp.Input

m-nash added this pull request to the merge queue

Merged via the queue into microsoft:main with commit 81b1692

ArcturusZhang mentioned this pull request

Move the GetSerializationTypeProviders on CodeModelPlugin to TypeFactory and rename it #3865

Closed

ArcturusZhang deleted the fix-base-type-issue branch

February 27, 2025 08:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:csharp