Merged
Conversation
msyyc
requested review from
iscai-msft,
lmazuel,
tadelesh and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:python
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
msyyc
commented
Apr 2, 2025
msyyc
changed the title
3 tasks
msyyc
commented
Apr 7, 2025
msyyc
changed the title
tadelesh
approved these changes
Apr 8, 2025
iscai-msft
approved these changes
Apr 8, 2025
lmazuel
reviewed
Apr 8, 2025
| export async function runPython3(...args: string[]) { | ||
| const command = await patchPythonPath(["python", ...args], { | ||
| version: ">=3.8", | ||
| version: ">=3.9", |
Member
There was a problem hiding this comment.
Technically speaking, using 3.8+ to generate and generating 3.8+ are two different things. For instance, we could technically have a generator written in Python 2.7, that generates Python 3.12 code :). In other words, the fact that our generator is written in Python is an implementation detail.
That being said, it's fair to ask people to have 3.8+, because it allows us as well to write the generator with more recent syntax.
lmazuel
approved these changes
Apr 8, 2025
Member
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
Nicee to see how we can simplify our code :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.