Multi-level discriminator handling improvements#9119
Merged
radhgupta merged 16 commits intomicrosoft:mainfrom Dec 5, 2025
Merged
Multi-level discriminator handling improvements#9119radhgupta merged 16 commits intomicrosoft:mainfrom
radhgupta merged 16 commits intomicrosoft:mainfrom
Conversation
Contributor
|
No changes needing a change description found. |
49cf471 to
f7c7cb6
Compare
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Show resolved
Hide resolved
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
commit: |
Collaborator
|
You can try these changes here
|
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the logic for handling multi-level discriminators in model constructor initialization within
ModelProvider.cs. The changes ensure more accurate passing of discriminator parameters in complex inheritance scenarios, improving both correctness and maintainability.Multi-level discriminator handling improvements
GetExpressionForCtorto correctly decide when to pass through the discriminator parameter or use the model's own discriminator value, based on whether the model is part of a multi-level discriminator hierarchy.Constructor initialization logic