Use configured cadl-server path in VS when using a solution #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
requested review from
allenjzhang,
bterlson,
daviwil,
markcowl and
timotheeguerin
as code owners
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/916/ |
timotheeguerin
approved these changes
Aug 24, 2022
| var options = Environment.GetEnvironmentVariable("CADL_SERVER_NODE_OPTIONS"); | ||
| var module = GetDevelopmentCadlServerPath(); | ||
| return ("node.exe", new string[] { module, options }.Concat(args).ToArray(), env); | ||
| var options = Environment.GetEnvironmentVariable("CADL_SERVER_NODE_OPTIONS"); |
Member
There was a problem hiding this comment.
hhm did the formatter not catch this before?
Contributor
Author
There was a problem hiding this comment.
It breaks with #if it seems, I ran VS format command :(
| } | ||
| else | ||
| { | ||
| // When a solution is open, there is no workspace settings manager, |
Member
There was a problem hiding this comment.
Can't believe they don't have this story sorted out.
Contributor
Author
|
I found some bugs and made substantial changes, will open a fresh PR when ready. |
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #660