Add spector case for extensible enum with special word member names#9785
Add spector case for extensible enum with special word member names#9785
Conversation
…ames Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
…n/json Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
|
@copilot check all changes of the PR to make sure they are consistent. |
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Reviewed all changes for consistency in f70bb68. Found and fixed one issue: the
Build passes with 61 valid scenarios. |
|
@copilot fix ci error: |
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…viewer feedback Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
|
Hi @timotheeguerin pls help take a review, thanks! |
…9987) moved from #9953 Follow-up to #9785: the `putExtensibleStringValue` operation was missing an explicit response content-type header, inconsistent with the pattern used by other extensible enum endpoints. - Updated return type in `packages/http-specs/specs/special-words/main.tsp`: ```typespec putExtensibleStringValue(@Body body: ExtensibleString): { @Header contentType: "application/json"; @Body body: ExtensibleString; }; ``` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `telemetry.astro.build` > - Triggering command: `/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/typespec/typespec/website/node_modules/.bin/../astro/astro.js build sh s/.b�� ../../website/sr--llmstxt sh _modules/pnpm/dist/node-gyp-bin/node --no-emit git _modules/pnpm/digenerate-scenarios-summary node tobu�� build.json sh /.bin/sh ld.json && pnpm node pnpm tobuf/reference node` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/microsoft/typespec/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/microsoft/typespec/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
special-words/main.tsp@putoperation per reviewer feedbackExtensibleStringreturn type so mock API echoes back the sent valueputExtensibleStringValue(@body body: ExtensibleString): ExtensibleString;@docdecorators from union definition for consistency with rest of fileunion Enumtounion ExtensibleStringto avoid blocking actual enum testsEnumstoExtensibleStrings, route/enumsto/extensible-strings, and operationputEnumValuetoputExtensibleStringValue✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.