Closed
Conversation
microsoft-github-policy-service
bot
added
the
emitter:client:python
commit: |
Contributor
|
All changed packages have been documented.
|
Collaborator
|
You can try these changes here
|
l0lawrence
requested review from
ChenxiJiang333,
catalinaperalta,
iscai-msft,
lmazuel,
mccoyp,
msyyc,
swathipil,
tadelesh and
timotheeguerin
as code owners
msyyc
reviewed
Mar 11, 2026
| pytest==8.3.2 | ||
| coverage==7.6.1 | ||
| black==24.8.0 | ||
| black==26.3.0 |
Contributor
There was a problem hiding this comment.
@l0lawrence Any context about why we need to upgrade to black 26 which requires python 3.10? Since autorest.python repo has CI items which runs in python3.9, this PR will break them.
Member
Author
There was a problem hiding this comment.
So there was an issue with black segfaulting on wsl ubuntu 24.04 in the current version we have pinned, but upgrading to a higher version fixed it. Since we drop 3.9 in May, I opened the prs against the most recent version of black
Member
Author
|
Closing black version seems to work without tsp-client, owner going to file an issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black to 26 - requires python 3.10