This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Open
Conversation
|
+1 vote for this PR |
|
Does this mean we're going to get those deprecation notifications until this PR gets approved and merged? |
AKarkhanis0804
approved these changes
Nov 28, 2022
onabison
approved these changes
Nov 29, 2022
onabison
left a comment
onabison
left a comment
There was a problem hiding this comment.
Simple update, looks harmless enough... who needs to approve?
|
I had to do a bit more to get this working with node 16, so it needs a bit more than just this PR I think. I ran into the same issue, and have forked the action in the meantime. You can find and use v1.1 from here: github.com/rajbos-actions/variable-substitution if this is blocking. |
Author
|
Since MS deprecated this action, I guess we'll have to switch to @rajbos solution. |
onabison
approved these changes
Dec 5, 2022
onabison
left a comment
onabison
left a comment
There was a problem hiding this comment.
Who do I need to sleep with for this merge to happen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update node to v16 in order to prevent node version warning on dependent wokflows.