[openimageio] Remove vcpkg_fail_port_install. #22752
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openimageio/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openimageio/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
|
Is there a hard hdf5 dependency? I guess it is wrong spelling in flann, #22731. |
I don't know. It's unlikely to be that issue though because flann is not in this dependency graph:
|
Cheney-W
added
category:port-bug
This doesn't say to much because The hdf5 issue also caught this fmt PR: #22707. And you probably wouldn't simply add hdf5 as a fmt dependency... |
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
No hdf5 dependency until proper research.
Cheney-W
removed
the
info:needs-maintainer-attention
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openimageio/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
strega-nil-ms
left a comment
strega-nil-ms
left a comment
There was a problem hiding this comment.
Waiting on @dg0yt's research.
ports/openimageio/vcpkg.json
Outdated
There was a problem hiding this comment.
This is at least wrong on osx, since I can install openimageio:x64-osx without hdf5
Admittedly I know almost nothing about hdf5 :) |
Separated out because it adds a supports expression to a feature. This port is not named in ci.baseline.txt. In support of microsoft#21502
# Conflicts: # versions/o-/openimageio.json
BillyONeal
force-pushed
the
remove_fail_port_install_openimageio
branch
from
248859a to
2e1921a
Compare
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openimageio/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
I didn't want to do that myself, because the ports I'm interested make enough work.
Inspecting the log of the build errror confirmed my guess: |
Yeah sorry, I was digging into that but had not gotten there yet. But Thanks! I will wait for #22731 |
BillyONeal
added
depends:different-pr
BillyONeal
removed
the
depends:different-pr
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openimageio/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
4 participants
Separated out because it adds a supports expression to a feature. This port is not named in ci.baseline.txt.
In support of #21502