Skip to content

Conversation

@Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Dec 19, 2022

depends on #26768

node-api is official C API for NodeJS

node-addon-api is C++ wrapper around node-api

github-actions[bot]
github-actions bot previously approved these changes Jan 5, 2023
@Pospelove
Copy link
Contributor Author

@JonLiu1993 Works now. Changed your cmakelists a bit:

added cxx standard and "unofficial" prefix for find_package

set(CMAKE_TOOLCHAIN_FILE "${CMAKE_CURRENT_LIST_DIR}/vcpkg/scripts/buildsystems/vcpkg.cmake")

# CMakeList.txt : CMake project for CMakeProject42, include source and define
# project specific logic here.
#
cmake_minimum_required (VERSION 3.8)

set(CMAKE_CXX_STANDARD 20) # !!! I added this 

project(test)

find_package(unofficial-node-addon-api CONFIG REQUIRED) # !!! and added unofficial word here

add_executable (main "CMakeProject42.cpp" "CMakeProject42.h")

target_link_libraries(main PRIVATE unofficial::node-addon-api::node-addon-api)

@dg0yt thanks. taking a look

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for node-addon-api have changed but the version was not updated
version: 5.0.0
old SHA: 11136d2ef81d78d628925881e7bc00381fa9ec5f
new SHA: bc084481bc02a7531ce5855cfcffd03721421c6a
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for node-addon-api have changed but the version was not updated
version: 5.0.0
old SHA: 11136d2ef81d78d628925881e7bc00381fa9ec5f
new SHA: bd0b6bedf60881a5c794a5362fb3fb21a3b55d15
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@Pospelove
Copy link
Contributor Author

@dg0yt @JonLiu1993 works and fixed

@Pospelove
Copy link
Contributor Author

@JonLiu1993

github-actions[bot]
github-actions bot previously approved these changes Jan 18, 2023
@JonLiu1993
Copy link
Contributor

@JonLiu1993

@Pospelove, sorry for reply you so late, after the CI turns green, I will put the reviewed label on the table after the local test is successful.

@Pospelove
Copy link
Contributor Author

@JonLiu1993
plz consider taking a look

@Pospelove
Copy link
Contributor Author

@JonLiu1993

@JonLiu1993
Copy link
Contributor

@Pospelove, sorry to reply you so late, we just came back from vacation, so we didn't respond to you in time.

github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2023
@JonLiu1993
Copy link
Contributor

Tested usage by node-addon-api:x64-windows triplet successfully.

@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 29, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new port!

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
    Note: There is a 5.1.0 already :)
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
    I added usage text
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@BillyONeal BillyONeal merged commit ce4d499 into microsoft:master Feb 1, 2023
@Pospelove Pospelove deleted the node-addon-api branch February 1, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants