[libclipboard] new port

[judemille]

• Changes comply with the maintainer guide
• The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
• Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
• The versioning scheme in vcpkg.json matches what upstream says.
• The license declaration in vcpkg.json matches what upstream says.
• The installed as the "copyright" file matches what upstream says.
• The source code of the component installed comes from an authoritative source.
• The generated "usage text" is accurate. See adding-usage for context.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is in the new port's versions file.
• Only one version is added to each modified port's versions file.

[judemille]

This repository is licensed under the MIT license. What reason is there to completely reassign my copyright to Microsoft? By contributing, I am licensing my changes under the MIT license. Is that not enough?

[judemille]

I can squash my crazy number of commits if need be.

[MonicaLiu0311]

This repository is licensed under the MIT license. What reason is there to completely reassign my copyright to Microsoft? By contributing, I am licensing my changes under the MIT license. Is that not enough?

CC @JavierMatosD @data-queue @BillyONeal

[dg0yt]

The patch seem more invasive than necessary.

[judemille]

@microsoft-github-policy-service agree

I morally disagree with the CLA, but it's clear to me that unless I give Microsoft the right to use my work without so much as a mention of my existence, no movement will happen.

[MonicaLiu0311]

The usage test passed on x64-windows (header files found):

The package libclipboard provides CMake targets:

    find_package(unofficial-libclipboard CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::libclipboard::clipboard)

[dg0yt]

I still think the patch is much too invasive, not minimal (as required by guidelines).
I also dislike the removal of the official pkg-config files.
An incomplete set of hints follows.
Disclaimer: I'm only a community member,

[dg0yt]

Why is this removed?

[judemille]

I'll admit, my brain went "not modern CMake, kill!". Perhaps I'll fork the repository to bring the CMake stuff up to standard, since it's not been updated in three years anyway.

[dg0yt]

Suggested change

- src/clipboard_cocoa.c

[judemille]

This file will not build in the slightest (even with definition guards) without an Objective-C compiler, which we don't want to assume the presence of unless Cocoa is requested (read: on a Mac).

[dg0yt]

Suggested change

	+if(LIBCLIPBOARD_BUILD_COCOA)
	+list(APPEND SOURCE src/clipboard_cocoa.c)
	endif()
	endif()

[judemille]

See my other comment.

[dg0yt]

It is easy to ensure that the file doesn't exist, so we don't need to remove all these lines.

[judemille]

Fair enough.

[JavierMatosD]

I agree with @dg0yt regarding the patch. I like the modernization, but we should really try to follow upstream's lead whenever possible and keep patch sizes down to a minimum. I'll place the PR on draft for now.

[JavierMatosD]

This repository is licensed under the MIT license. What reason is there to completely reassign my copyright to Microsoft? By contributing, I am licensing my changes under the MIT license. Is that not enough?

Our lawyers told us that this is the reason:

Microsoft asks that all contributors agree to a contributor license agreement (CLA). CLAs are generally common and accepted in most open source software projects. We all want Microsoft's open source projects to be as widely used and distributed as possible. We also want its users to be confident about the origins and continuing existence of the code. The CLA help us achieve that goal by ensuring that we have the agreement of our contributors to use their work, whether it be code, or documentation.

Microsoft to distribute your code without restriction. It doesn't require you to assign to us any copyright you have, the ownership of the copyright remains with you. You cannot withdraw permission for use of the contribution at a later date.

We are generally seeking originally authored code and documentation as contributions. Should you wish to submit materials that are not your original work, you may submit them separately to the Project in accordance with the terms of the CLA.

[MonicaLiu0311]

Thanks for your contribution. If you're ready, please revert to "ready for review". If not, please continue working on this PR.

[MonicaLiu0311]

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.