[opentelemetry-cpp] Add opentracing shim feature#44012
Merged
JavierMatosD merged 2 commits intoFeb 26, 2025
Merged
Conversation
JonLiu1993
added
category:port-feature
JonLiu1993
commented
Feb 25, 2025
| HEAD_REF main | ||
| PATCHES | ||
| cmake-quirks.diff | ||
| fix-target_link.patch |
Contributor
Author
There was a problem hiding this comment.
Fix error:
CMake Error at opentracing-shim/CMakeLists.txt:26 (target_link_libraries):
Target "opentelemetry_opentracing_shim" links to:
OpenTracing::opentracing
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
Contributor
Author
|
Tested usage successfully in the following triplet:
|
jimwang118
added
the
info:needs-maintainer-attention
Contributor
|
Another 👎 PR. 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43974
Add opentracing shim feature
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.