[libevent] Upgrade CMake 3.5#44356
Closed
JonLiu1993 wants to merge 2 commits into
Closed
Conversation
added 2 commits
March 13, 2025 01:40
JonLiu1993
added
category:port-bug
Contributor
|
Consider fixing the regressions in #44273 instead so we can simply move everything to support CMake 4 |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (4)
- ports/libevent/portfile.cmake: Language not supported
- ports/libevent/vcpkg.json: Language not supported
- versions/baseline.json: Language not supported
- versions/l-/libevent.json: Language not supported
My understanding is that this pull request here would also add support for CMake 4.0, but I haven't tested this myself. (#44273 looks like it should be compatible with the changes here, and also looks still in progress/discussion, so it may be better to move forward here first?) |
Contributor
Author
|
Replaced by PR #44712 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44336
I have submitted an issue on upstream: libevent/libevent#1782
Failed due to https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.