Skip to content

[cryptopp] take latest bug-fixes from cryptopp-cmake#44463

Closed
rressi-at-globus wants to merge 5 commits into
microsoft:masterfrom
globusmedical:feature/cryptopp_8.9.0#2
Closed

[cryptopp] take latest bug-fixes from cryptopp-cmake#44463
rressi-at-globus wants to merge 5 commits into
microsoft:masterfrom
globusmedical:feature/cryptopp_8.9.0#2

Conversation

@rressi-at-globus
Copy link
Copy Markdown
Contributor

@rressi-at-globus rressi-at-globus commented Mar 18, 2025

Description

The cryptopp library is build using 2 repositories:

Now, I have recently fixed an issue with the build of the library with this PR on the second repo and then I had a nice chat you can review on that PR with the author about hot to better bring this fix here.

We both agreed that the best way was to just take the current commit on master from abdes/cryptopp-cmake:

  • we are still building weidai11/cryptopp, version 8.9.0
  • but with some porting fixes on top related to how we build it.

You can consult it the list of changes (20 commits in total):

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Mar 19, 2025
@Cheney-W
Copy link
Copy Markdown
Contributor

The current method of updating to the latest commit requires changing the version field in vcpkg.json to version-date. However, this modification prevents version comparisons when using this port in manifest mode. I believe that if you can communicate with the upstream, could you request them to release a new tag? This way, updating with the new tag would not only fix the bug but also avoid impacting manifest mode.

@BillyONeal
Copy link
Copy Markdown
Member

The current method of updating to the latest commit requires changing the version field in vcpkg.json to version-date.

As long as upstream is involved and the installed sources are substantially identical to 8.9.0 I think we can probably take this as a different port-version.

@BillyONeal
Copy link
Copy Markdown
Member

As long as upstream is involved and the installed sources are substantially identical to 8.9.0

Unfortunately looking at abdes/cryptopp-cmake@CRYPTOPP_8_9_0...edb9a71 there are meaningful product code changes :(

If what you need is just abdes/cryptopp-cmake#128 perhaps you could just add that patch for now?

@rressi-at-globus rressi-at-globus force-pushed the feature/cryptopp_8.9.0#2 branch from a2c1070 to d0af4c7 Compare December 1, 2025 06:33
@rressi-at-globus
Copy link
Copy Markdown
Contributor Author

This PR has been replaced by this second attempt to have something mergeable with upstream:

@rressi-at-globus rressi-at-globus deleted the feature/cryptopp_8.9.0#2 branch December 1, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants