Skip to content

[dlpack] update to 1.1#44679

Merged
BillyONeal merged 3 commits into
microsoft:masterfrom
snnn:snnn/update_dlpack
Apr 7, 2025
Merged

[dlpack] update to 1.1#44679
BillyONeal merged 3 commits into
microsoft:masterfrom
snnn:snnn/update_dlpack

Conversation

@snnn
Copy link
Copy Markdown

@snnn snnn commented Mar 28, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Also, add a patch to add cmake 4.0 compatibility.
CMake 4.0 has dropped the support for cmake version < 3.5

Changming Sun added 2 commits March 28, 2025 12:33
@snnn snnn changed the title Update DLPack Update DLPack From 1.0 to 1.1 Mar 28, 2025
@snnn snnn changed the title Update DLPack From 1.0 to 1.1 [dlpack] update to 1.1 Mar 28, 2025
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Mar 31, 2025
Comment thread ports/dlpack/portfile.cmake Outdated
@snnn snnn requested a review from LilyWangLL April 1, 2025 18:41
LilyWangLL
LilyWangLL previously approved these changes Apr 2, 2025
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 2, 2025
@snnn snnn marked this pull request as draft April 3, 2025 00:39
@snnn
Copy link
Copy Markdown
Author

snnn commented Apr 3, 2025

Need to hold on. Anyway vcpkg doesn't support cmake 4.0 yet.

@BillyONeal BillyONeal marked this pull request as ready for review April 7, 2025 19:19
@BillyONeal
Copy link
Copy Markdown
Member

CMake version issue was resolved by #44712 though we would still encourage upstream maintainers to use a reasonably current CMake version there going forward.

@BillyONeal BillyONeal enabled auto-merge (squash) April 7, 2025 19:20
@BillyONeal BillyONeal merged commit 556e8b4 into microsoft:master Apr 7, 2025
18 checks passed
@snnn snnn deleted the snnn/update_dlpack branch April 7, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants