Skip to content

[blosc] Fix build with CMake 4.0#44733

Closed
chrismile wants to merge 1 commit into
microsoft:masterfrom
chrismile:fix-blosc-cmake
Closed

[blosc] Fix build with CMake 4.0#44733
chrismile wants to merge 1 commit into
microsoft:masterfrom
chrismile:fix-blosc-cmake

Conversation

@chrismile
Copy link
Copy Markdown
Contributor

This PR fixes the compilation of the blosc port with CMake 4.0, which removed compatibility with versions of CMake older than 3.5. This issue was fixed four days ago in the upstream repo (Blosc/c-blosc@051b9d2), but as vcpkg uses stable version releases of blosc, the proposed patch (which is exactly identical to the commit in the upstream repo) might be reasonable until a new stable version of blosc is released.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@BillyONeal
Copy link
Copy Markdown
Member

Is this needed after #44712 ?

@Mengna-Li Mengna-Li self-assigned this Apr 2, 2025
@Mengna-Li Mengna-Li added category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Apr 2, 2025
@vicroms
Copy link
Copy Markdown
Member

vicroms commented Apr 3, 2025

Fixed via #44712

@vicroms vicroms closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants