Skip to content

[ktx] Fix broken msys package download links#45040

Merged
BillyONeal merged 3 commits into
microsoft:masterfrom
kring:ktx-msys-links
Apr 15, 2025
Merged

[ktx] Fix broken msys package download links#45040
BillyONeal merged 3 commits into
microsoft:masterfrom
kring:ktx-msys-links

Conversation

@kring
Copy link
Copy Markdown
Contributor

@kring kring commented Apr 15, 2025

Installing the ktx port on Windows currently fails because it attempts to download msys2 packages that are no longer hosted on repo.msys2.org. This PR updates the links to point to valid packages.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Apr 15, 2025

With the next update to vcpkg_acquire_msys, we should probably add these packages there so that they are covered by the freshness check in the vcpkg-ci-msys2 port.

(No change requested to this PR.)

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Apr 15, 2025

With the next update to vcpkg_acquire_msys, we should probably add these packages there so that they are covered by the freshness check in the vcpkg-ci-msys2 port.

OTOH this would make it more difficult to get rid of the maintenance burden when we could get rid of these dependnencies. Maybe we find a better way to put this under test automation.

@Mengna-Li Mengna-Li added category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Apr 15, 2025
@BillyONeal BillyONeal merged commit ca2c883 into microsoft:master Apr 15, 2025
18 checks passed
@BillyONeal
Copy link
Copy Markdown
Member

Thanks!

@kring kring deleted the ktx-msys-links branch April 15, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants