[slick-logger] Use find_package to find slick-logger#48408
Merged
Conversation
4e1556a to
740dcef
Compare
Contributor
Author
|
After changing the I'm getting Anyone an idea why? |
5d9e5da to
976bef2
Compare
Contributor
Frequent issue: You see an effect of concurrent write access to the source directory. Vcpkg prefers to configure debug and release in parallel. Normally fine, but ... One of your earlier pushes already touched the relevant spot: There is an easy fix: Add |
976bef2 to
c725433
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vicroms
approved these changes
Nov 20, 2025
Member
vicroms
left a comment
There was a problem hiding this comment.
LGTM, retrying CI due to unrelated issues.
luadebug
pushed a commit
to luadebug/vcpkg
that referenced
this pull request
Nov 21, 2025
geiseri
pushed a commit
to geiseri/vcpkg
that referenced
this pull request
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.#48301 added a new port, which causes the update of CMake in #48250 to fail after the last rebase there. Issue is the policy
CMP0170, which causes:As
slick_queuewas also recently added in #48297, I think it's fine whenslick-loggerdepends on it instead of downloading it again.// Edit: Even with
find_packageI'm getting now on the CI hereMaybe an regression due to the Android update in #48366?