Skip to content

[slick-logger] Use find_package to find slick-logger#48408

Merged
vicroms merged 1 commit into
microsoft:masterfrom
SunBlack:slick-logger_fix
Nov 21, 2025
Merged

[slick-logger] Use find_package to find slick-logger#48408
vicroms merged 1 commit into
microsoft:masterfrom
SunBlack:slick-logger_fix

Conversation

@SunBlack
Copy link
Copy Markdown
Contributor

@SunBlack SunBlack commented Nov 20, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

#48301 added a new port, which causes the update of CMake in #48250 to fail after the last rebase there. Issue is the policy CMP0170, which causes:

CMake Warning at /vcpkg/downloads/tools/cmake-3.31.10-linux/cmake-3.31.10-linux-x86_64/share/cmake-3.31/Modules/FetchContent.cmake:2111 (message):
  FETCHCONTENT_FULLY_DISCONNECTED is set to true, which requires the source
  directory for dependency slick_queue to already be populated.  This
  generally means it must not be set to true the first time CMake is run in a
  build directory.  The following source directory should already be
  populated, but it doesn't exist:

    /mnt/vcpkg-ci/b/slick-logger/x64-android-dbg/_deps/slick_queue-src

  Policy CMP0170 controls enforcement of this requirement.
Call Stack (most recent call first):
  /vcpkg/downloads/tools/cmake-3.31.10-linux/cmake-3.31.10-linux-x86_64/share/cmake-3.31/Modules/FetchContent.cmake:2384 (__FetchContent_Populate)
  CMakeLists.txt:19 (FetchContent_MakeAvailable)


CMake Error at CMakeLists.txt:24 (configure_file):
  No such file or directory


-- Slick Queue: /mnt/vcpkg-ci/b/slick-logger/x64-android-dbg/_deps/slick_queue-src
-- Testing disabled - skipping slick_logger tests
-- Skipping slick_logger examples
-- slick_logger: 1.0.1
-- Configuring incomplete, errors occurred!

As slick_queue was also recently added in #48297, I think it's fine when slick-logger depends on it instead of downloading it again.

// Edit: Even with find_package I'm getting now on the CI here

CMake Error at CMakeLists.txt:15 (configure_file):
  No such file or directory

Maybe an regression due to the Android update in #48366?

@SunBlack SunBlack force-pushed the slick-logger_fix branch 2 times, most recently from 4e1556a to 740dcef Compare November 20, 2025 11:18
@SunBlack
Copy link
Copy Markdown
Contributor Author

After changing the configure_file line to

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/logger.hpp ${CMAKE_CURRENT_SOURCE_DIR}/include/slick/logger.hpp)

I'm getting

CMake Error at CMakeLists.txt:15 (configure_file):
  Permission denied

Anyone an idea why?

@SunBlack SunBlack force-pushed the slick-logger_fix branch 5 times, most recently from 5d9e5da to 976bef2 Compare November 20, 2025 15:54
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Nov 20, 2025

Anyone an idea why?

Frequent issue: You see an effect of concurrent write access to the source directory. Vcpkg prefers to configure debug and release in parallel. Normally fine, but ...

One of your earlier pushes already touched the relevant spot: configure_file(...).

There is an easy fix: Add DISABLE_PARALLEL_CONFIGURE in vcpkg_cmake_configure (before OPTIONS).

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Nov 20, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, retrying CI due to unrelated issues.

@vicroms vicroms enabled auto-merge (squash) November 20, 2025 23:38
@vicroms vicroms merged commit cc4df03 into microsoft:master Nov 21, 2025
17 checks passed
@SunBlack SunBlack deleted the slick-logger_fix branch November 21, 2025 00:26
luadebug pushed a commit to luadebug/vcpkg that referenced this pull request Nov 21, 2025
geiseri pushed a commit to geiseri/vcpkg that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants