Skip to content

[OpenImageIO] Remove deprecated dependency on AGL#48424

Closed
tophyr wants to merge 6 commits into
microsoft:masterfrom
tophyr:remove-agl-framework
Closed

[OpenImageIO] Remove deprecated dependency on AGL#48424
tophyr wants to merge 6 commits into
microsoft:masterfrom
tophyr:remove-agl-framework

Conversation

@tophyr
Copy link
Copy Markdown
Contributor

@tophyr tophyr commented Nov 21, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase the port version in port/openimageio/vcpkg.json and run vcpkg x-add-version openimageio to update the versions database.

@vicroms vicroms marked this pull request as draft November 21, 2025 04:06
@tophyr tophyr marked this pull request as ready for review November 21, 2025 04:09
@tophyr tophyr requested a review from vicroms November 21, 2025 04:11
vicroms
vicroms previously approved these changes Nov 21, 2025
@vicroms vicroms enabled auto-merge (squash) November 21, 2025 04:12
@tophyr
Copy link
Copy Markdown
Contributor Author

tophyr commented Nov 21, 2025

@vicroms done! i was surprised that the git-tree hash changed - i have a hunch that i'm not thinking about git-tree correctly. does that represent the raw git hash of the commit to be downloaded (AcademySoftwareFoundation/OpenImageIO tag v3.0.9.2 in this case) or does it represent some sort of hash after the patches are applied? The former doesn't seem like it would have changed from this PR, but the latter certainly would.

@tophyr
Copy link
Copy Markdown
Contributor Author

tophyr commented Nov 21, 2025

vcpkg-applied patches causing changes in the git-tree hash would also explain many of the confusing version-database failures i've been having while tinkering on other PRs

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Nov 21, 2025

The git-tree is a hash of the contents of the port's folder; it is calculated with git ls-tree and it can be used to recover the contents using git show <git-tree>.

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Nov 21, 2025

I suspect there is a missing find_dependency(CpuFeaturesNdkCompat ) introduced by #48311 in opencv4 that is causing the Android failures.

@dg0yt dg0yt mentioned this pull request Nov 21, 2025
@luadebug luadebug mentioned this pull request Nov 21, 2025
@tophyr
Copy link
Copy Markdown
Contributor Author

tophyr commented Nov 24, 2025

@vicroms calling mayday here - i'm a bit lost as to what's failing. hitting the build links from this verification run, and then opening up the "artifacts produced" link in the azure pipeline, takes me to a page listing failure artifacts from builds that didn't fail in this run:
image
image
image
image

this has me doubting the correctness of the logs of the runs that did fail - especially because opencv4:x64-android succeeds locally for me on both windows and linux hosts, on this commit. i'm unsure how to make CI happy, or figure out whatever is actually failing - any advice?

@tophyr
Copy link
Copy Markdown
Contributor Author

tophyr commented Nov 24, 2025

ah; i take back the "works on my machine" - i always forget that CI builds different flavors than i do by default. building openimageio[core,ffmpeg,freetype,gif,jpegxl,libheif,libraw,opencolorio,opencv,openjpeg,pybind11,tools,webp]:x64-android does indeed repro the (a?) failure.

still fairly mystified by the non-failing failure artifacts in the azure pipeline though.

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Nov 24, 2025

still fairly mystified by the non-failing failure artifacts in the azure pipeline though.

There are expected failures for arm64 windows.

vcpkg/scripts/ci.baseline.txt

Lines 1026 to 1031 in edffab1

# OpenCV appears to be trying to use __fp16 on a platform that does not support that
# buildtrees\opencv4\src\4.11.0-46ecfbc8ae.clean\modules\dnn\src\layers\cpu_kernels\conv_winograd_f63.simd.hpp(1371): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
#vcpkg-ci-opencv:arm64-windows-static-md=pass
opencv4:arm64-windows-static-md=fail
#vcpkg-ci-opencv:arm64-windows=pass
opencv4:arm64-windows=fail

and then openimageio is a cascading error and not an expected pass.

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Nov 24, 2025

I suspect there is a missing find_dependency(CpuFeaturesNdkCompat ) introduced by #48311 in opencv4 that is causing the Android failures.

#48451 should resolve this.

auto-merge was automatically disabled November 24, 2025 22:47

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants