[libevent] Add thread as default feature#9101
Merged
dan-shaw merged 1 commit intoDec 20, 2019
Merged
Conversation
JackBoosY
approved these changes
Nov 27, 2019
NancyLi1013
added
the
info:needs-maintainer-attention
Contributor
|
I don't think this change is needed. bitcoin/bitcoin#17592 fixes this. edit: I think this change is fine. |
dan-shaw
approved these changes
Dec 11, 2019
Contributor
|
This would be useful as some of our systems unexpectedly broke when threading was removed from the default install. We've updated according but libevent should have threading by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we disable support
threadfor this port, it will cause some errors in Bitcoin Core msvc build.So I add
threadas the default feature oflibevent.I also updated the deprecated functions.
Related PR #8349.
All features test pass with the following triplets:
x86-windows
x64-windows-static
arm64-windows
x64-linux
x64-uwp (not supported)