Skip to content
This repository was archived by the owner on Dec 6, 2022. It is now read-only.

Update Break On Load Details #960

Merged
roblourens merged 1 commit intomicrosoft:masterfrom
stephencweiss:master
Dec 12, 2019
Merged

Update Break On Load Details #960
roblourens merged 1 commit intomicrosoft:masterfrom
stephencweiss:master

Conversation

@stephencweiss
Copy link
Contributor

As of microsoft/vscode-chrome-debug-core#241 the breakOnLoad has been part of the configuration options for the Chrome Debugger.

This MR is meant to update the README in relevant sections to assist in understanding how to use this feature.

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just please fix your git email address so that your commit is properly attributed to your github account.

@stephencweiss
Copy link
Contributor Author

@roblourens -- by git email address, do you mean the github one? I've made it public now. If you meant something else, I'm not sure what that might have been.

@roblourens
Copy link
Member

I mean the actual git email address, note that your commit is not assciated with your github account:
image

https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address#setting-your-commit-email-address-in-git

@stephencweiss
Copy link
Contributor Author

Cool - thanks @roblourens

I think I fixed this ... and learned something new about git configs in the process :)

Cheers!

image

@roblourens
Copy link
Member

Thanks!

@roblourens roblourens merged commit d334dd7 into microsoft:master Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants