Added More Commands Back by alexyaang · Pull Request #4031 · microsoft/vscode-docker

alexyaang · 2023-08-10T20:14:40Z

logOutOfDockerCli

untagAzureImage
viewAzureProperties
buildImageInAzure

alexyaang · 2023-08-10T20:15:03Z

Going into #4026

resources/azureSubscription.svg

alexyaang · 2023-08-10T20:17:00Z

src/commands/registries/azure/tasks/scheduleRunRequest.ts


        const azureRegistryClient = await createAzureContainerRegistryClient(registry.subscription);
-        const uploadedSourceLocation: string = await uploadSourceCode(azureRegistryClient, registry.subscription.subscriptionId, resourceGroup, rootUri, tarFilePath);
+        const uploadedSourceLocation: string = await uploadSourceCode(azureRegistryClient, registry.label, resourceGroup, rootUri, tarFilePath);


this was a typo from earlier 😞

alexyaang · 2023-08-10T20:18:00Z

src/tree/registries/Azure/AzureRegistryDataProvider.ts


-export type AzureRegistry = V2Registry & AzureRegistryItem;
+export type AzureRegistry = V2Registry & AzureRegistryItem & {
+    readonly registryProperties: AcrRegistry;


added this so we can add back the view view azure properties command

alexyaang · 2023-08-10T20:18:32Z

src/tree/registries/Azure/AzureRegistryDataProvider.ts

                    subscription: sub,
-                    additionalContextValues: ['azuresubscription']
+                    additionalContextValues: ['azuresubscription'],
+                    iconPath: vscode.Uri.joinPath(this.extensionContext.extensionUri, 'resources', 'azureSubscription.svg'),


this is where the icon will be used (subscription tree item)

look something like this (which is also what it used to look like)

resources/azureSubscription.svg

src/tree/registries/Azure/AzureRegistryDataProvider.ts

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

alexyaang · 2023-08-11T13:52:59Z

We already have this icon. As part of build it gets copied into the resources from the Azure utils package. That happens here: https://github.com/microsoft/vscode-docker/blob/main/webpack.config.js#L74 That being said, if the icon is now the only thing we're using from the azureutils package, which might be the case after we move the appsvc deployment out into the appsvc extension, I'd rather dump the azureutils package and keep just the icon.

@bwateratmsft Sounds good. Although I do believe we still need the azure-utils package for creating a new azure registry (unless we want to redo all steps)

* adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * added back create azure registry command * move createAzureClient to azureUtils * added viewAzureProperties command back (partially) * small tweak to make build image in azure work * added untag azure image commad * added logout of docker cli command * add case sensitivity operator to be consistent * Update src/tree/registries/Azure/AzureRegistryDataProvider.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * added void * removed symbol as it already exists --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

* added view docker hub item in browser command * updated npm package * Added More Commands Back (#4031) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * added back create azure registry command * move createAzureClient to azureUtils * added viewAzureProperties command back (partially) * small tweak to make build image in azure work * added untag azure image commad * added logout of docker cli command * add case sensitivity operator to be consistent * Update src/tree/registries/Azure/AzureRegistryDataProvider.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * added void * removed symbol as it already exists --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * minor tweak to avoid index out of bounds * use built in methods to determine the type of item --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

* Registries V2 (#4021) * saving progress * added context values for copy full tag * added back copy remote image digest * comment out commands that are not implemented yet * added disconnext registry function back * small fixes to adjust to new changes * Made Some ACR Commands Work (#4027) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * Added Back `createAzureRegistry` command (#4029) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * added back create azure registry command * move createAzureClient to azureUtils * Added More Commands Back (#4031) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * added back create azure registry command * move createAzureClient to azureUtils * added viewAzureProperties command back (partially) * small tweak to make build image in azure work * added untag azure image commad * added logout of docker cli command * add case sensitivity operator to be consistent * Update src/tree/registries/Azure/AzureRegistryDataProvider.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * added void * removed symbol as it already exists --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * Added Back Open Docker Hub Item in Browser (#4033) * added view docker hub item in browser command * updated npm package * Added More Commands Back (#4031) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * added back create azure registry command * move createAzureClient to azureUtils * added viewAzureProperties command back (partially) * small tweak to make build image in azure work * added untag azure image commad * added logout of docker cli command * add case sensitivity operator to be consistent * Update src/tree/registries/Azure/AzureRegistryDataProvider.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * added void * removed symbol as it already exists --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * minor tweak to avoid index out of bounds * use built in methods to determine the type of item --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * Added Back `pushImage()` (#4034) * make pushImage work * added getAllRegistries command * added getLoginInformation() * account for cases where registry in undefined * added filtering to make get all registries more optima * added logic to filter github repositories * Added Back Azure Deploy to ACA & Azure Deploy to AAS (#4038) * added back basic implementation of deploy ACA * saving progress * added step for selecting subscriptions * small tweaks * progress on deploy image to azure app service * improved azure subscription selection experience * actually made deploy image to AAS work * remove accidetal change to settings.json * fix small mistake * fixed more mistakes * fix more mistakes * fixed even more mistakes... * Implemented Delete Remote Image for GenericV2 (#4039) * added logic for copy remote imgage digest * added back delete image * refined logic for delete image * fixed pushImage * reverted changes to registryExperience * tag logic for GitHub * be able to debug github image * added back skipIfOne flag * Added Untag Image Command for Azure RDP (#4041) * adjusted context values * added untag Image * remove github option for delete tag * commtag -> v2tag * slighty changed context values * Improve UX for Connecting & Disconnecting Generic V2 Registries (#4043) * added remove tracked registry command * added command to add generic v2 registry * Update package.nls.json Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * Update package.nls.json Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * added logic for reconnect (#4045) * Cleanup Registries Implementation (#4046) * fixed genericV2 pull image bug * improved utils to use outside methods * enable copyImageDigest for all v2 registries * removed run task & did TODOs * did TODOs * use baseUrl * polished up contextValues * fixed push image error for dockerhub * removed azure account listener * actually removed AzureAccountExtensionListener * made minor adjustments based in brandon's comments * use azutils for open in azure portal * Fix subscription icon * Small fix * minor changes to imports * Remove GitHub package transitive dependency * Version was wrong * allow delete image command show up on commontag * fix miake in deleteImage * simplified logic in pushImage (#4062) * simplify logic in deploy to Azure app service (#4063) * handle contextValueExperience edge case * changed isWrappedItem function name to be more specific * Added fire soon function to AzureRDP (#4066) * added fire soon * clear time out * Change fireSoon to take callback function (#4071) * change firesoon to take callback function * use RDP label when determining type of registry * use new RegistryV2RequestOptions for azure requests * Improve Registry Experience & Simplify Context Values (#4076) * added implementation * added comments * use RegistryQuickPickStep for everything * fix regex * fix viewproperties context value package json * remove unnecessary method * added back necessary logic * Commit current progress * Commit current progress * adjust package.json * fix azure typo * preserve existing additional context value * make regex more robust --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * remove unnecessary comment * uploaded & changed azext package version * Asynchronously fetch createdAt info (#4074) * Add registry extensibility capability (#4061) * remove generic v2 root if it's the last one * get registries package from npm * Trigger Build * actually get npm from npm org * update azext util package to use npm org --------- Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

alexyaang added 15 commits August 8, 2023 16:48

adjusted scheduleRunReuqest to work with new registries tree

f9be94e

delete azure repository command implementation

ea30d6d

actually added back delete azure repository

d9402ce

added back delete Azure Registry command

08c05fc

changed registry tree util file name to be more general

d3bb8b8

added openInAzurePortalCommand

f96dc3e

added back create azure registry command

b5324aa

merged with registries branch

26939df

move createAzureClient to azureUtils

1ffa022

Merge branch 'yangalex/registries' into yangalex/azureRegistries

73be5cc

added viewAzureProperties command back (partially)

f5cc7d6

small tweak to make build image in azure work

395cdc6

added untag azure image commad

ae12187

added logout of docker cli command

8c42a18

add case sensitivity operator to be consistent

c7e06cf

alexyaang commented Aug 10, 2023

View reviewed changes

resources/azureSubscription.svg Outdated Show resolved Hide resolved

alexyaang commented Aug 10, 2023

View reviewed changes

alexyaang marked this pull request as ready for review August 10, 2023 20:18

alexyaang requested a review from a team as a code owner August 10, 2023 20:18

bwateratmsft approved these changes Aug 11, 2023

View reviewed changes

resources/azureSubscription.svg Outdated Show resolved Hide resolved

src/tree/registries/Azure/AzureRegistryDataProvider.ts Outdated Show resolved Hide resolved

alexyaang and others added 2 commits August 11, 2023 09:43

Update src/tree/registries/Azure/AzureRegistryDataProvider.ts

88309ab

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

added void

ee370f6

removed symbol as it already exists

733c9ca

alexyaang merged commit bdac083 into yangalex/registries Aug 11, 2023

alexyaang deleted the yangalex/azureRegistries branch August 11, 2023 16:23

microsoft locked and limited conversation to collaborators Sep 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added More Commands Back#4031

Added More Commands Back#4031
alexyaang merged 18 commits intoyangalex/registriesfrom
yangalex/azureRegistries

alexyaang commented Aug 10, 2023 •

edited

Loading

Uh oh!

alexyaang commented Aug 10, 2023

Uh oh!

Uh oh!

alexyaang Aug 10, 2023

Uh oh!

alexyaang Aug 10, 2023

Uh oh!

alexyaang Aug 10, 2023

Uh oh!

alexyaang Aug 10, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

alexyaang commented Aug 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

alexyaang commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexyaang commented Aug 10, 2023

Uh oh!

Uh oh!

alexyaang Aug 10, 2023

Choose a reason for hiding this comment

Uh oh!

alexyaang Aug 10, 2023

Choose a reason for hiding this comment

Uh oh!

alexyaang Aug 10, 2023

Choose a reason for hiding this comment

Uh oh!

alexyaang Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alexyaang commented Aug 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexyaang commented Aug 10, 2023 •

edited

Loading

alexyaang Aug 10, 2023 •

edited

Loading