No Longer Expose Ports Manually During Sdk Build & Launch#4081
Merged
No Longer Expose Ports Manually During Sdk Build & Launch#4081
Conversation
bwateratmsft
approved these changes
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With .NET 8 SDK RC1, images that are built has existing expose ports logic so we no longer need to export 8080 and 80 manually.
This also closes #4006 since the old behavior in
browseContainer()would just choose80by default and open a port that is not published for .NET 8. However, with the new SDK exposing ports change and us not exposing ports manually, the only available port is the port auto exposed by the .NET SDK (8080), therefore, fixing the problem.