Change run commands to use imageId instead of tag#4112
Merged
bwateratmsft merged 4 commits intomicrosoft:mainfrom Oct 18, 2023
Merged
Change run commands to use imageId instead of tag#4112bwateratmsft merged 4 commits intomicrosoft:mainfrom
bwateratmsft merged 4 commits intomicrosoft:mainfrom
Conversation
alexyaang
reviewed
Oct 12, 2023
alexyaang
reviewed
Oct 12, 2023
Co-authored-by: Alex Yang [MSFT] <59073590+alexyaang@users.noreply.github.com>
Co-authored-by: Alex Yang [MSFT] <59073590+alexyaang@users.noreply.github.com>
bwateratmsft
approved these changes
Oct 12, 2023
Collaborator
bwateratmsft
left a comment
bwateratmsft
left a comment
There was a problem hiding this comment.
This looks good to me. We'll need to wait until 1.27.0 is released as we're right in the middle of a release test pass. This change can go into 1.28.0.
Contributor
Author
|
Thank you @bwateratmsft |
Collaborator
|
Now that 1.27.0 is released I'll merge this. Thank you again @jnsjunior! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The purpose of this pull request is to solve issue #4100 .
Unit tests:
1- Build an untagged image:
Example Dockerfile
Build
Untagged image built
2- Run it (interactive):
Run interactive
Check running
Check image ID
