Skip to content

Use Node 18, drop node-fetch #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwateratmsft merged 3 commits into from
Nov 22, 2023
Merged

Use Node 18, drop node-fetch #4167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf8d9cf
Bump to use node 18
bwateratmsft Nov 13, 2023
f7827da
Update dependencies and refactor streamToFile
bwateratmsft Nov 13, 2023
ba84aae
Update @microsoft/vscode-docker-registries
bwateratmsft Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.17
18.15
58 changes: 27 additions & 31 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 5 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2929,7 +2929,7 @@
]
},
"engines": {
"vscode": "^1.75.0"
"vscode": "^1.82.0"
},
"capabilities": {
"virtualWorkspaces": false,
Expand Down Expand Up @@ -2971,10 +2971,9 @@
"@types/fs-extra": "^11.0.1",
"@types/glob": "^7.2.0",
"@types/mocha": "^10.0.1",
"@types/node": "^16.18.24",
"@types/node-fetch": "^2.6.3",
"@types/node": "18.x",
"@types/semver": "^7.3.13",
"@types/vscode": "1.75.0",
"@types/vscode": "1.82.0",
"@types/xml2js": "^0.4.11",
"@typescript-eslint/eslint-plugin": "^5.59.0",
"@typescript-eslint/parser": "^5.59.0",
Expand All @@ -2999,17 +2998,16 @@
"@azure/storage-blob": "^12.14.0",
"@microsoft/compose-language-service": "^0.2.0",
"@microsoft/vscode-azext-azureappservice": "~2.0",
"@microsoft/vscode-azext-azureauth": "^1.3.0",
"@microsoft/vscode-azext-azureauth": "^1.4.0",
"@microsoft/vscode-azext-azureutils": "^2.0.0",
"@microsoft/vscode-azext-utils": "^2.1.1",
"@microsoft/vscode-container-client": "^0.1.1",
"@microsoft/vscode-docker-registries": "^0.1.7",
"@microsoft/vscode-docker-registries": "^0.1.8",
"dayjs": "^1.11.7",
"dockerfile-language-server-nodejs": "^0.11.0",
"fs-extra": "^11.1.1",
"gradle-to-js": "^2.0.1",
"handlebars": "^4.7.7",
"node-fetch": "^2.6.9",
"semver": "^7.5.2",
"tar": "^6.1.13",
"vscode-languageclient": "^8.1.0",
Expand Down
6 changes: 4 additions & 2 deletions src/utils/httpRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*--------------------------------------------------------------------------------------------*/

import * as fse from 'fs-extra';
import { default as fetch, Request, RequestInit, Response } from 'node-fetch';
import { URL, URLSearchParams } from 'url';
import { l10n } from 'vscode';

Expand Down Expand Up @@ -133,7 +132,10 @@ export interface ResponseLike {
export async function streamToFile(downloadUrl: string, fileName: string): Promise<void> {
const response = await fetch(downloadUrl);
const writeStream = fse.createWriteStream(fileName);
response.body.pipe(writeStream);

for await (const chunk of response.body) {
writeStream.write(chunk);
}

return new Promise((resolve, reject) => {
writeStream.on('close', () => {
Expand Down