Skip to content

Update the Dockerfile Language Server to 0.14.0#4553

Merged
karolz-ms merged 2 commits intomicrosoft:mainfrom
rcjsuen:update-lsp-0.14.0
Apr 11, 2025
Merged

Update the Dockerfile Language Server to 0.14.0#4553
karolz-ms merged 2 commits intomicrosoft:mainfrom
rcjsuen:update-lsp-0.14.0

Conversation

@rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Apr 11, 2025

This update includes some general fixes as well as one to prevent the language server crashing (#4408). It also includes an update to how we handle links so that we no longer just blindly route everything to Docker Hub.

Please use the Dockerfile below to reproduce the crash and verify the fix.

FROM scratch
RUN <<<CRASH
CRASH

FROM scratch

Please use the Dockerfile below to test the other fixes and the update to the URL links.

# Ctrl+Clicking on alpine on line 3 should not jump to line 4,
# they're not referencing the same thing
FROM alpine
FROM hello AS alpine

# click on "base" on lines 11, 12, and 14
# only lines 11 and 14 will be highlighted,
# the new release highlights line 12 as well,
# then try repeating the steps with renaming,
# same problem, same fix
FROM busybox AS base
FROM base
FROM busybox
COPY --from=base . .

# links should go to the right place instead of all jumping to Docker Hub
# Docker Hub
FROM busybox
# GitHub Container Registry
FROM ghcr.io/super-linter/super-linter
FROM ghcr.io/super-linter/super-linter:latest-buildcache
# Microsoft Artifact Repository
FROM mcr.microsoft.com/powershell
FROM mcr.microsoft.com/powershell:3.17
FROM mcr.microsoft.com/windows/servercore
FROM mcr.microsoft.com/windows/servercore:ltsc2025
# Quay.io
FROM quay.io/prometheus/node-exporter:v1.9.1

This update includes some general fixes as well as one to prevent the
language server crashing. It also includes an update to how we handle
links so that we no longer just blindly route everything to Docker Hub.

Signed-off-by: Remy Suen <remy.suen@docker.com>
@rcjsuen rcjsuen requested a review from a team as a code owner April 11, 2025 10:41
Signed-off-by: Remy Suen <remy.suen@docker.com>
@karolz-ms
Copy link
Contributor

Thanks Remy 🤗

@karolz-ms karolz-ms enabled auto-merge (squash) April 11, 2025 16:05
@karolz-ms karolz-ms merged commit 94303ef into microsoft:main Apr 11, 2025
2 checks passed
@rcjsuen rcjsuen deleted the update-lsp-0.14.0 branch April 11, 2025 16:33
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Apr 11, 2025

Thanks for the review, Karol! This release also fixes another crash. I don't believe it was reported here but I thought I would mention it anyway. :)

RUN <<'END_OF_PATCH
END_OF_PATCH
RUN <<'SCRIPT'
SCRIPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong heredoc kills Docker LS

2 participants