Fix .gitignore files not included in npm package#364
Merged
bpasero merged 1 commit intomicrosoft:mainfrom Aug 8, 2022
mboultoureau:main
Merged
Fix .gitignore files not included in npm package#364bpasero merged 1 commit intomicrosoft:mainfrom mboultoureau:main
bpasero merged 1 commit intomicrosoft:mainfrom
mboultoureau:main
Conversation
|
|
|
Tagging maintainers @hawkticehurst @aeschli @joyceerhl: this bug is breaking setup for every user using this generator so seems pretty critical to merge |
bpasero
approved these changes
Aug 8, 2022
Member
|
Thank you! |
Member
|
Ah! I was out of the office when this happened and am finally catching up on old issues now. Thank you so much for the fix @mboultoureau (and @danawoodman for the call out) 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #363 : missing .gitignore files in NPM Package. Rename
.gitignorefiles togitignoreand change the copy instructions..gitgnore files cannot be included in packages (npm/npm#3763).