Skip to content

Implement envFile (Issue #523)#928

Merged
testforstephen merged 5 commits intomicrosoft:masterfrom
chase:master
Jan 13, 2021
Merged

Implement envFile (Issue #523)#928
testforstephen merged 5 commits intomicrosoft:masterfrom
chase:master

Conversation

@chase
Copy link
Copy Markdown
Contributor

@chase chase commented Dec 26, 2020

Implemented envFile to close #523

Uses some code from https://github.com/microsoft/vscode-js-debug to parse env files

@testforstephen

@ghost
Copy link
Copy Markdown

ghost commented Dec 26, 2020

CLA assistant check
All CLA requirements met.

@ShimonBenYair
Copy link
Copy Markdown

ShimonBenYair commented Jan 6, 2021

@chase

How can I check your PR to see if it works for me ?
Can you please write the steps here

@chase
Copy link
Copy Markdown
Contributor Author

chase commented Jan 6, 2021

@testforstephen testforstephen self-requested a review January 7, 2021 08:44
Copy link
Copy Markdown
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good.

@testforstephen testforstephen added this to the 0.31.0 milestone Jan 12, 2021
Copy link
Copy Markdown
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for your contribution.

@testforstephen testforstephen merged commit 9be9832 into microsoft:master Jan 13, 2021
@troyspencer
Copy link
Copy Markdown

Thanks for working on this, I've been waiting on somebody to handle that port for a while. I built and installed from this branch and it works great, except the edge case of clicking restart in the debugger uses the values from the previous run instead of loading from the file like pressing start does. Until I realized, my iterations on environment file updates while migrating a dev setup seemed fruitless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

envFile option for debugger in launch mode

4 participants