Skip to content

fix: Should recognize test classes with '$' in their names#1366

Merged
jdneo merged 2 commits intomainfrom
cs/issue-1364
Jan 25, 2022
Merged

fix: Should recognize test classes with '$' in their names#1366
jdneo merged 2 commits intomainfrom
cs/issue-1364

Conversation

@jdneo
Copy link
Copy Markdown
Member

@jdneo jdneo commented Jan 25, 2022

fix #1364.

According to the API document, CompilationUnit.findDeclaringNode() will return null when:

  • if the corresponding node cannot be determined.
  • if bindings were not requested when this AST was built.

While ASTNodeSearchUtil works in this case.

Note: there are other usages for CompilationUnit.findDeclaringNode(), will consider if they should also be replaced to ASTNodeSearchUtil.

Signed-off-by: sheche sheche@microsoft.com

jdneo added 2 commits January 25, 2022 11:25
@jdneo
fix: Should recognize test classes with '$' in their names
bc0b384 
Signed-off-by: sheche <sheche@microsoft.com>
@jdneo
Update changelog
dc2e173 
Signed-off-by: sheche <sheche@microsoft.com>
@jdneo jdneo added the bug label Jan 25, 2022
@jdneo jdneo added this to the 0.34.0 milestone Jan 25, 2022
@jdneo jdneo requested a review from testforstephen January 25, 2022 03:31
@jdneo jdneo merged commit 49ea8ec into main Jan 25, 2022
@jdneo jdneo deleted the cs/issue-1364 branch January 25, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@testforstephen testforstephen testforstephen approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

0.34.0

Development

Successfully merging this pull request may close these issues.

Test Explorer doesn't recognize test classes with '$' in their names

2 participants

@jdneo @testforstephen