Skip to content

Fixed how parameterized test methods are sorted#1515

Merged
jdneo merged 2 commits intomicrosoft:mainfrom
Kropie:cs/paramaterized_test_sort_fix
Dec 23, 2022
Merged

Fixed how parameterized test methods are sorted#1515
jdneo merged 2 commits intomicrosoft:mainfrom
Kropie:cs/paramaterized_test_sort_fix

Conversation

@Kropie
Copy link
Copy Markdown
Contributor

@Kropie Kropie commented Dec 21, 2022

Fixed how parameterized test methods are sorted to ensure that they use a natural sort.

to ensure that they use a natural sort.
@Kropie
Copy link
Copy Markdown
Contributor Author

Kropie commented Dec 21, 2022

This PR will address issue #1465. See the attached screenshot to see the fix in action:
image

@jdneo
Copy link
Copy Markdown
Member

jdneo commented Dec 22, 2022

Thank you @Kropie! I'll take a look recently.

Meanwhile, could you fix the linting errors first? You can run npm run lint to find out where are the errors.

@jdneo jdneo self-requested a review December 22, 2022 01:48
@jdneo jdneo linked an issue Dec 22, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one small change request.

@Kropie Kropie requested a review from jdneo December 22, 2022 03:09
Copy link
Copy Markdown
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Kropie for your contribution!

@jdneo jdneo merged commit a1f020c into microsoft:main Dec 23, 2022
@jdneo jdneo added this to the 0.38.0 milestone Dec 23, 2022
@jdneo jdneo added the bug label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parameterized tests: sorting should be natural instead of alphabetical

2 participants