Duplicate names fix

[Kropie]

Fixes #1517

Solution Description

When creating test IDs for TestNG and JUnit5 tests, the method parameters are included in the test IDs. This allows for multiple tests of the same name to be correctly identified on the server and the client.

[jdneo]

Just some small pieces.

BTW, I noticed that you deleted the changes in junit5/AppTest. I suggest keeping that. Although we covered it in the test cases but imagine if the output format of the test runner changes, we can still leverage it to do some quick manual verification.

[Kropie]

Just some small pieces.

BTW, I noticed that you deleted the changes in junit5/AppTest. I suggest keeping that. Although we covered it in the test cases but imagine if the output format of the test runner changes, we can still leverage it to do some quick manual verification.

I'll go ahead and bring the changes back then

[jdneo]

I tested the change for TestNG project. looks like there is some problem parsing the test suite:

See:

vscode-java-test/java-extension/com.microsoft.java.test.runner/src/main/java/com/microsoft/java/test/runner/testng/TestNGLauncher.java

Line 61 in 0c14d0b

private static String getMethodName(String clazz) {

Now the method name will contain the parameter types, but I found that TestNG has some problem if the method name contains parameter types. (It cannot find the test method in this case)

One quick workaround can change the return statement to return clazz.substring(clazz.lastIndexOf("#") + 1, clazz.indexOf("("));, though it will trigger all the test methods with the same name. But that looks like a problem of TestNG itself.

BTW, the argument name clazz is misleading. It's test id actually.

You can use the following test class to verify:

import org.testng.Assert;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;

public class CharUtilsTest {

	@DataProvider
	public Object[][] ValidDataProvider() {
		return new Object[][]{
				{ 'A', 65 },{ 'a', 97 },
				{ 'B', 66 },{ 'b', 98 },
				{ 'C', 67 },{ 'c', 99 },
				{ 'D', 68 },{ 'd', 100 },
				{ 'Z', 90 },{ 'z', 122 },
				{ '1', 49 },{ '9', 517 }
 
		};
	}

	@Test(dataProvider = "ValidDataProvider")
	public void CharToASCIITest(final char character, final int ascii) {
		int result = CharUtils.CharToASCII(character); 
		Assert.assertEquals(result, ascii);
	}

	 @Test
	 public void CharToASCIITest() {
	 	Assert.assertEquals(1, 2);
 	 }
}

[Kropie]

I tested the change for TestNG project. looks like there is some problem parsing the test suite:

See:

vscode-java-test/java-extension/com.microsoft.java.test.runner/src/main/java/com/microsoft/java/test/runner/testng/TestNGLauncher.java

Line 61 in 0c14d0b

private static String getMethodName(String clazz) {

Now the method name will contain the parameter types, but I found that TestNG has some problem if the method name contains parameter types. (It cannot find the test method in this case)

One quick workaround can change the return statement to return clazz.substring(clazz.lastIndexOf("#") + 1, clazz.indexOf("("));, though it will trigger all the test methods with the same name. But that looks like a problem of TestNG itself.

BTW, the argument name clazz is misleading. It's test id actually.

You can use the following test class to verify:

import org.testng.Assert;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;

public class CharUtilsTest {

	@DataProvider
	public Object[][] ValidDataProvider() {
		return new Object[][]{
				{ 'A', 65 },{ 'a', 97 },
				{ 'B', 66 },{ 'b', 98 },
				{ 'C', 67 },{ 'c', 99 },
				{ 'D', 68 },{ 'd', 100 },
				{ 'Z', 90 },{ 'z', 122 },
				{ '1', 49 },{ '9', 517 }
 
		};
	}

	@Test(dataProvider = "ValidDataProvider")
	public void CharToASCIITest(final char character, final int ascii) {
		int result = CharUtils.CharToASCII(character); 
		Assert.assertEquals(result, ascii);
	}

	 @Test
	 public void CharToASCIITest() {
	 	Assert.assertEquals(1, 2);
 	 }
}

Just made some updates to resolve this issue with testng tests.

[jdneo]

Thank you @Kropie! All the changes look good to me.

This is a complex one, but you get it done so so well. 🎉