Clicking on find references result leads to a textDocument/didOpen without a close

[stamblerre]

Versions used

1.48.0-insider
0a7364f00514c46c9caceece15e1f82f82e3712f
x64

vscode-language-client version: 7.0.0-next.7

I'm not sure if this is a VS Code or language client issue, so please transfer this if it's the wrong repository.
After calling find references, I clicked on the link to the file in the results (shown in the image below).

This sent a textDocument/didOpen request for the file in question (server_gen.go). I then navigated back to the file explorer view and never looked at the references results again, but the server never received a textDocument/didClose for the file. I also tried clearing the results, but that also did not send a textDocument/didClose.

Is this intended behavior? Some of the logic in the Go language server relies on showing different diagnostics if a file is opened or closed, and this results in some unexpected behavior.

Thanks!

[dbaeumer]

@jrieken can you please comment on this. I am pretty sure that the event is not lost in the LSP client. I guess the file will never be closed in VS Code itself.

[vscodebot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[dbaeumer]

Reopeing and ping a @jrieken

[kjeremy]

I can reproduce this using rust-analyzer (which does not use the node lsp server)

[kjeremy]

@jrieken

[kjeremy]

I believe that this can be closed. In vscode there is a 3 minute timer for references. Once triggered it sends a didClose notification.

[dbaeumer]

@kjeremy thanks for getting back. Closing then.