Draft
Conversation
added 2 commits
April 2, 2025 17:27
…start a bash otherwise the call from parser will not work
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #716
i don't usually code in typeskript so i don't know how usefull this is.
also i could only test on a windows -> msys setup.
The fix is somewhat convoluted, since child_process.spawn does not appear to support specifying shell arguments.
i also didn't let 'cmd' / '/bin/bash' commands execute via the specified shell, because escaping the caracters correctly seems impossible; this affects the call from parser.ts
the setup also only works if gcc is in PATH, but that seems to be because c_cpp extension does not use the provided shell to lookup system path from the given compiler.