Fix switch regex to not match numeric values like -1 inside quoted strings#761
Draft
Fix switch regex to not match numeric values like -1 inside quoted strings#761
Conversation
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix parseCompilerArgs.bat failure with space in argument
Fix parseCompilerArgs.bat failure when arguments contain spaces in quoted strings
Jan 23, 2026
Contributor
|
@copilot I'm getting the following errors now when I run included.h exists under the included directory too |
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Contributor
Author
... Fixed in f1de702. The issue was that when The fix adds a |
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copilot
AI
changed the title
Fix parseCompilerArgs.bat failure when arguments contain spaces in quoted strings
Fix switch regex to not match numeric values like -1 inside quoted strings
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseCompilerArgs.batfails when parsing macro definitions containing numeric expressions like-D'LFS_ASSERT(test)'='do { if(!(test)) {return -1;} } while(0)'. The-1inside the quoted value was incorrectly matched as a compiler switch.Root Cause
The regex pattern
([a-zA-Z0-9_]+)inparseAnySwitchFromToolArgumentsmatches any alphanumeric sequence after-, including-1. This splits quoted strings at the wrong boundary.Fix
Require switch names to start with a letter:
This prevents numeric tokens like
-1,-2, etc. from being matched as switches while still matching valid switches like-D,-Wall,-std.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.