Escape special regex characters in additionalCompilerNames#768
Draft
Escape special regex characters in additionalCompilerNames#768
Conversation
…ling Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix exception by improving makefile.additionalCompilerNames handling
Escape special regex characters in additionalCompilerNames
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-provided compiler names in
makefile.additionalCompilerNamescontaining regex metacharacters (e.g.,nios2-elf-g++) cause "Invalid regular expression: Nothing to repeat" exceptions during configure. Built-in compilers likeg++are pre-escaped in source, but user additions were not.Changes
src/util.ts: AddescapeStringForRegex()to escape regex metacharacters (. * + ? ^ $ { } ( ) | [ ] \)src/parser.ts: EscapeadditionalCompilerNamesentries before regex constructionsrc/test/fakeSuite/extension.test.ts: Add test suite for regex escapingExample
Before (throws):
After:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0psvsblobprodwus2145.vsblob.vsassets.io/usr/local/bin/node /usr/local/bin/node /usr/local/bin/yarn install(dns block)8wdvsblobprodwus2137.vsblob.vsassets.io/usr/local/bin/node /usr/local/bin/node /usr/local/bin/yarn install(dns block)b15vsblobprodwus2164.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install(dns block)b53vsblobprodwus2154.vsblob.vsassets.io/usr/local/bin/node /usr/local/bin/node /usr/local/bin/yarn install(dns block)isovsblobprodwus211.vsblob.vsassets.io/usr/local/bin/node /usr/local/bin/node /usr/local/bin/yarn install(dns block)lusvsblobprodwus2166.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install(dns block)pkwvsblobprodwus2126.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install(dns block)v41vsblobprodwus2175.vsblob.vsassets.io/usr/local/bin/node /usr/local/bin/node /usr/local/bin/yarn install(dns block)vd2vsblobprodwus2150.vsblob.vsassets.io/usr/local/bin/node /usr/local/bin/node /usr/local/bin/yarn install(dns block)vjmvsblobprodwus2182.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install(dns block)vm9vsblobprodwus2190.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install(dns block)wlnvsblobprodwus2188.vsblob.vsassets.io/usr/local/bin/node /usr/local/bin/node /usr/local/bin/yarn install(dns block)y1rvsblobprodwus2136.vsblob.vsassets.io/usr/local/bin/node /usr/local/bin/node /usr/local/bin/yarn install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
makefile.additionalCompilerNameshandling to automatically escape characters like+#712💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.