Skip to content

Support single quotes in dryrun output for mingw-make compatibility#773

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/add-dryrun-output-support
Draft

Support single quotes in dryrun output for mingw-make compatibility#773
Copilot wants to merge 4 commits intomainfrom
copilot/add-dryrun-output-support

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

  • Understand the issue: mingw-make uses single quotes around tool invocation instead of double quotes
  • Identify the affected code: parseLineAsTool function in src/parser.ts (lines 390 and 402)
  • Update the regex pattern in parseLineAsTool to accept both single and double quotes
  • Verify regex patterns work correctly with unit test
  • Run code review and address feedback (fixed inconsistent quote escaping)
  • Run CodeQL security check (no issues found)
  • Add unit tests for single quote support (mingw-make style tool invocations)
Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature] Support mingw-make's dryrun output format</issue_title>
<issue_description>### Request Overview

Add support for single quotes around the tool invocation within the dryrun output.

This is needed to support make variants which use single quotes instead of double quotes in their dry run output, such an mingw-make.

Additional Information

No response</issue_description>

<agent_instructions>Please also add tests if it makes sense to.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 29, 2026 20:42
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copilot AI changed the title [WIP] Add support for mingw-make's dryrun output format Support single quotes in dryrun output for mingw-make compatibility Jan 29, 2026
Copilot AI requested a review from snehara99 January 29, 2026 20:46
@snehara99
Copy link
Contributor

@copilot can you add a test to cover the case in issue #739?

…ssue #739)

Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 3, 2026

@copilot can you add a test to cover the case in issue #739?

Added unit tests for the single quote support in commit 6e7c5e7. The new test suite covers:

  • Double-quoted tool invocations (original behavior)
  • Single-quoted tool invocations (mingw-make style)
  • Unquoted tool invocations
  • Path extraction with various quote styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support mingw-make's dryrun output format

2 participants