Skip to content

execute mvn with maven.settingsFile#776

Merged
Eskibear merged 3 commits intomicrosoft:mainfrom
emliunix:main
Jan 10, 2022
Merged

execute mvn with maven.settingsFile#776
Eskibear merged 3 commits intomicrosoft:mainfrom
emliunix:main

Conversation

@emliunix
Copy link
Copy Markdown
Contributor

@emliunix emliunix commented Jan 8, 2022

Re-create PR #768 because it's accidentally closed.

Original description:

Now that we have maven.settingsFile config, it seems natural to execute mvn with it (which I found out not.)
Is there any concern not doing so.

@ghost
Copy link
Copy Markdown

ghost commented Jan 8, 2022

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eskibear Eskibear merged commit 137610c into microsoft:main Jan 10, 2022
@Eskibear Eskibear added this to the January 2022 milestone Jan 10, 2022
@Eskibear
Copy link
Copy Markdown
Member

@jdneo
To verify:

  1. open a Maven project.
  2. modify setting maven.settingsFile and point it to a valid settings.xml
  3. run a maven goal, verify if -s settings.xml is appended to the command.
  4. create a new project, also verify command line in the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants