Temp fix for linux and mac sql server 2025 image #19918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenastrid1
requested review from
Benjin,
aasimkhan30,
caohai,
kburtram and
lewis-sanchez
as code owners
PR Changes
|
Contributor
Author
|
Can someone merge this? I still have the permissions error that doesn't allow merging |
Benjin
reviewed
Aug 12, 2025
Benjin
reviewed
Aug 12, 2025
Benjin
reviewed
Aug 12, 2025
Benjin
reviewed
Aug 12, 2025
Benjin
added a commit
that referenced
this pull request
Aug 12, 2025
Benjin
approved these changes
Aug 12, 2025
Benjin
added a commit
that referenced
this pull request
Aug 12, 2025
Benjin
added a commit
that referenced
this pull request
Aug 12, 2025
5 tasks
kburtram
pushed a commit
that referenced
this pull request
Aug 12, 2025
laurenastrid1
added a commit
that referenced
this pull request
Aug 19, 2025
* temp fix for linux and mac sql server 2025 image * check for arm mac * added latest to string; remove uneccessary state updates in form validation * fix broken test * pr comments --------- Co-authored-by: Lauren Nathan <laurennathan@microsoft.com>
5 tasks
Benjin
pushed a commit
that referenced
this pull request
Aug 19, 2025
* temp fix for linux and mac sql server 2025 image * check for arm mac * added latest to string; remove uneccessary state updates in form validation * fix broken test * pr comments --------- Co-authored-by: Lauren Nathan <laurennathan@microsoft.com>
Benjin
added a commit
that referenced
this pull request
Aug 22, 2025
* Sanitize container input (#19896) * sanitize hostname * cleaned up code, and renamed files to follow convention --------- Co-authored-by: Lauren Nathan <laurennathan@microsoft.com> * Adding screenshots for visual debugging of smoketests (#19913) * adding screenshots for debugging connection e2e tests * setting smoketests to run in 1080p * Add improved logging and telemetry to schema compare controller (#19891) * Improve telemetry and add operation ID prop * Add correlation ID to logs, to make debugging simpler * Add improved telemetry to reducers * Add optional chaining * Minor changes * Minor change * Fix build error * fixed tests --------- Co-authored-by: Lauren Nathan <laurennathan@microsoft.com> * Improvement (not fix) for Bug #18837: Query Cancellation and Disposal Now Handled Correctly (#19885) * Improves error handling and state reset for query actions Ensures consistent state reset and cleanup after errors during query cancellation and disposal. Removes references to non-existent runner unregistration. Enhances feedback and event emission on failures to prevent orphaned promises and incomplete executions. * All tests now pass * Improve error message handling in cancel operation * Refactored repeated code into a new private method _handleCancelDisposeCleanup() * Localized strings * conformed localization to proper standards (hopefully) * removed unnecessary commented out code --------- Co-authored-by: Sam Gusick <Sam.Gusick@galenhealthcare.com> * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 184739416 (#19915) * Add Copy as CSV and JSON functionality to query results (#19577) * Initial plan for issue * Add Copy as CSV and JSON functionality to query results - Add copyResultsAsCsv and copyResultsAsJson methods to QueryRunner - Add CSV and JSON formatting with proper escaping and configuration support - Add RPC handlers for copyAsCsv and copyAsJson - Add context menu items for Copy as CSV and Copy as JSON - Add unit tests for new copy functionality - Reuse existing CSV configuration from save functionality Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> * Add Copy as CSV/JSON support to Angular views - Add context menu items for Copy as CSV and Copy as JSON in Angular views - Add keyboard shortcut handlers for the new copy actions - Add DataService methods for copyAsCsv and copyAsJson - Add IServerProxy interface methods for new copy functionality - Ensure full compatibility with both React and Angular UI systems Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> * Fixing contracts * Remove redundant workspace configuration setup in Query Runner tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> Co-authored-by: Aasim Khan <aaskhan@microsoft.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> * Juno: check in to lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20250808153735814. (#19919) * Add Monaco-powered text view mode for query results with enhanced UX and fixed numbering (#19850) * Initial plan * Implement text view mode for query results with toggle functionality Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> * Complete text view feature implementation with documentation Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> * Address feedback: Fix result numbering and integrate Monaco editor for text view * Fix column alignment in text view mode - calculate widths from both headers and data Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> * fix display string. * update description for default query results view mode * Localizing string and removing unused package. * Add localization strings for row count and error messages in text view * More loc strings. * Add localization for result set index and update command bar icon * Log error when generating text view * Converting to enum * Add getEOL function to determine line endings based on the user's OS * Removing dup result data. * Merging all results sets into and simplifying command bar * remove console error. * loc strings. * Add localization for "Loading text view..." message * Remove deprecated monaco-editor dependency from yarn.lock * making command bar vertical in text view. * Refactor renderResultSet to include total grid count and improve grid management * Rename divId for clarity and update showOtherGrids parameter for better readability * Add GetEOLRequest to retrieve OS-specific end of line character --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: Aasim Khan <aaskhan@microsoft.com> * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 184874680 (#19920) * Defaulting sts to vscode locale instead of system locale (#19924) * defaulting sts to vscode locale * Remove unnecessary trans-unit for VSCode localization configuration * Fixing whitespace issue * Add localization setting to README for mssql extension * fixing whitespace * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 184893522 (#19926) * move sqlcmd toggle to context menu, fix command palette (#19755) * move sqlcmd toggle to context menu, fix command palette * remove context menu * Juno: check in to lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20250809153810788. (#19928) * Temp fix for linux and mac sql server 2025 image (#19918) * temp fix for linux and mac sql server 2025 image * check for arm mac * added latest to string; remove uneccessary state updates in form validation * fix broken test * pr comments --------- Co-authored-by: Lauren Nathan <laurennathan@microsoft.com> * updating changelog to include mention of #19918 (#19935) * Fixing password handling logic and adding temp session password for unsaved password conns. (#19925) * Implement password management improvements in connection handling * Consolidating duplicate code. * loc * Refactor password storage handling in connection management * remove clear passwords * removing dup code. * Fixing tests. * Consolidating logic and simplifying password lookup * Add telemetry events for password lookup in ConnectionStore * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 185366945 (#19936) * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 185370475 (#19939) * Not copying connections for sql files opened from internal extension … (#19929) * Not copying connections for sql files opened from internal extension code. * Refactor untitled SQL document service to improve URI tracking and operation handling * fixing test compilations. * Enhance MainController tests with sinon sandbox for better isolation and stubbing * Refactor MainController tests to reuse untitledSqlDocumentService mock and improve callback assertions * Fixing tests. * Renaming stuff * removing unused imports * fix tests * Enhance MainController tests by adding mock setups for untitledSqlDocumentService and ensuring proper async handling in onDidOpenTextDocument calls * compile * Fixing row limit on text view. (#19948) * Additional Schema Compare Telemetry (#19946) * Add action preferences telemetry * Telemetry for Schema Size Metrics * Add telemetry for options * Improved Options Telemetry * Add operationId prop * Change individual telemetry properties to JSON blob * Remove unnecessary comments * Remove missed comment * Remove missed comment * Juno: check in to lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20250814153713747. (#19958) * Automatically prune invalid/corrupted Entra account entries in global state (#19959) * checkpoint * working * loc * fixing tests * PR comments * Juno: check in to lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20250815153935672. (#19962) * Juno: check in to lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20250816153959059. (#19964) * Juno: check in to lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20250817153708144. (#19965) * Adding owner to CODEOWNERS list (#19967) * adding owner * removing * Setting database to it original value when saving to recent list (fix for bug 18992) (#19934) * setting to save database to it original value in the MRU list instead of using the value from connection * copying object to avoid changing the object values * pr feedback * tests fixes * tests fix --------- Co-authored-by: Allan Cascante <acascante@microsoft.com> * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 186232456 (#19968) * Update CHANGELOG and README for version 1.35.0 release notes and GA features (#19970) * - Updated CHANGELOG with v1.35 changes - Updated README with GA features - Updated README links * Adding a couple of missing mentions * Adding a couple of missing mentions * Removing preview tag from GA features * bumping main to 1.36 (#19974) * Enhanced CSV export configuration with enum options for encoding and delimiter (#19567) * Initial plan for issue * Enhanced CSV export configuration with enum options for encoding and delimiter Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> * Update localization files after configuration enhancements * Refactor save results tests to use sinon for stubbing and improve test isolation --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> Co-authored-by: Aasim Khan <aaskhan@microsoft.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> * Fixing webview type check (#19977) * Adding ability to filter unit tests. (#19978) * Fixing notification listeners in query runners. (#19982) * removing trailing space in ToS link (#19975) * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 186544038 (#19990) * Adding Result set count and updating splash screen (#19997) * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 186683626 (#19998) * Fixing package installer js file. (#20000) * Fix race conditions in webview view, open in tab and reveal panel (#19994) * Refactor query result handling and execution plan integration in SqlOutputContentProvider and related components * Hiding queryResults when not opened in new tab by default * Moving updating resultset to sqloutputcontentprovider. * Fixing execution plan service initialization. * Fixing tests * Refactor SqlOutputProvider tests to use sinon sandbox for stubbing * Rename revealQueryResultPanel to revealQueryResult for consistency across commands and improve clarity in the codebase. * push loc * Reset internal timers in onDidCloseTextDocument test for clean state * Returning early * Localized file check-in by OneLocBuild Task: Build definition ID 36521: Build ID 186797806 (#20006) * Fixing stuff (#20007) * loc --------- Co-authored-by: laurenastrid1 <151488703+laurenastrid1@users.noreply.github.com> Co-authored-by: Lauren Nathan <laurennathan@microsoft.com> Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com> Co-authored-by: Sam Gusick <sgusick@uvm.edu> Co-authored-by: Sam Gusick <Sam.Gusick@galenhealthcare.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: aasimkhan30 <6816294+aasimkhan30@users.noreply.github.com> Co-authored-by: Aasim Khan <aaskhan@microsoft.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: CSIGS@microsoft.com <csigs@users.noreply.github.com> Co-authored-by: Drew Skwiers-Koballa <dzsquared@users.noreply.github.com> Co-authored-by: allancascante <allan.cascante@gmail.com> Co-authored-by: Allan Cascante <acascante@microsoft.com> Co-authored-by: Carlos Robles <contact@croblesm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
Temporarily pull working Sql Server 2025 for mac and linux environments, until this bug is fixed: microsoft/mssql-docker#940 (comment)
Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines