Revert commit 61db6fcf to fix shutdown crash on macOS#68
Revert commit 61db6fcf to fix shutdown crash on macOS#68nickeyme wants to merge 1 commit intomicrosoft:release/vscodefrom
Conversation
|
@microsoft-github-policy-service agree |
deepak1556
left a comment
There was a problem hiding this comment.
Thank you for the minimal test case in the issue, as for the change can you adjust TRY_CATCH_CALL to capture the exception in the shutdown case. It seems incorrect to mix NAPI_DISABLE_CPP_EXCEPTIONS=1 when c++ exception handling is enabled.
|
Unfortunately, I was not able to reproduce this crash with Node, so as a form of defensive programming, I fixed this here, by silently ignoring exceptions during shutdown: |
|
Originally, I wanted to keep my fork somewhat similar with this one, and therefore I also enabled the C++ exceptions. |
fix issue (#67)