PR shows completely different changes in GitHub view vs Pull Request view

[RikkiGibson]

• Extension version (web): v0.34.3
• VSCode Version (web): 1.63.2
• Browser: Microsoft Edge Version 97.0.1072.62

Steps to Reproduce:

1. Open https://github.dev/dotnet/roslyn/pull/57667
2. Observe changes in CSharpCompilation.cs in "GitHub Pull Request" tab
3. Open the same PR in the "GitHub" tab and find the changes in CSharpCompilation.cs

Expected behavior: equivalent file changes shown in both places
Actual behavior: different file changes are shown in each place

Note that the changes in "GitHub" are correct while the changes in "GitHub Pull Request" are incorrect.

GitHub view:

GitHub Pull Request view:

[alexr00]

@RikkiGibson Does this happen every time you open that PR? I'm not able to repro the issue.

If it does happen every time, would you be willing to try the pre-release version of the extension and see if it also reproduces there?

[RikkiGibson]

I looked again and the "GitHub Pull Request" view is still wrong, but wrong in a new way :)

Switching to pre-release actually fixes the issue. Thanks for the tip!

I wonder if a specific issue was fixed between stable and pre-release? Did you use the version from the issue description when attempting to repro?

[alexr00]

I tried both stable and pre-release when trying to repro, but no luck on either. There are some significant refactors to improve performance in pre-release, so something could have fixed it.

[alexr00]

@RikkiGibson do you still see this? I haven't seen the issue through my daily use yet.

[RikkiGibson]

I think dotnet/roslyn#57667 still shows some bad behavior in my Edge, but other pull requests seem to work fine. I wonder if some local cache got into a bad state specifically for that pull request.

[alexr00]

I wonder if some local cache got into a bad state specifically for that pull request.

That could be it. Could you try going to https://vscode.dev/github/dotnet/roslyn/pull/57667 and seeing if it repros there?

[RikkiGibson]

Fascinating. Right now I get the gray bars indicating I can leave a comment, but no actual content diffs in github.dev:

In vscode.dev/github I get the proper content diffs:

[alexr00]

The no diffs is caused by microsoft/vscode-remote-repositories-github#121 We're still trying to get to the bottom of that one.

I think it's safe to say that the original issue was caused by caching though if you can't repro it on vscode.dev. If you see the incorrect diffs (not the no diffs) again, lets reopen for further investigation since we shouldn't end up with a bad cache.

Thank you for trying this out!