Skip to content

Add lint rule and remove axios #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
queerviolet merged 3 commits into from
May 13, 2019
Merged

Add lint rule and remove axios #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0232ed
Add whitespace:check-branch lint rule and fix problems.
May 13, 2019
57aed17
Remove spurious console.log
May 13, 2019
7b28663
Remove axios.
May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions ThirdPartyNotices.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,33 +330,6 @@ SOFTWARE.
END OF bitinn/node-fetch NOTICES AND INFORMATION


%% axios/axios NOTICES AND INFORMATION BEGIN HERE
=========================================
The MIT License (MIT)

Copyright (c) 2014-present Matt Zabriskie

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
=========================================
END OF axios/axios NOTICES AND INFORMATION


%% stefanpenner/es6-promise NOTICES AND INFORMATION BEGIN HERE
=========================================
Copyright (c) 2014 Yehuda Katz, Tom Dale, Stefan Penner and contributors
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,6 @@
"@octokit/rest": "^15.15.1",
"apollo-boost": "^0.1.22",
"apollo-link-context": "^1.0.12",
"axios": "^0.18.0",
"debounce": "^1.2.0",
"es6-promise": "^4.2.5",
"git-credential-node": "^1.1.0",
Expand Down
1 change: 0 additions & 1 deletion preview-src/comment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ function CommentBox({
for: comment,
onMouseEnter, onMouseLeave, children }: CommentBoxProps) {
const { user, author, createdAt, htmlUrl } = comment;
console.log('comment=', comment)
return <div className='comment-container comment review-comment'
{...{onMouseEnter, onMouseLeave}}
>
Expand Down
4 changes: 2 additions & 2 deletions src/common/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Log {
}

public appendLine(message: string, component?: string) {
switch(this._logLevel) {
switch (this._logLevel) {
case LogLevel.Off:
return;
case LogLevel.Debug:
Expand Down Expand Up @@ -53,7 +53,7 @@ class Log {

private getLogLevel() {
let logLevel = vscode.workspace.getConfiguration(SETTINGS_NAMESPACE).get<string>(LOG_LEVEL_SETTING);
switch(logLevel) {
switch (logLevel) {
case 'debug':
this._logLevel = LogLevel.Debug;
break;
Expand Down
3 changes: 1 addition & 2 deletions src/common/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export async function promiseFromEvent<T, U>(
try {
Promise.resolve(adapter(value, resolve, reject))
.catch(reject);
} catch(error) {
} catch (error) {
reject(error);
}
})
Expand Down Expand Up @@ -326,7 +326,6 @@ export class TernarySearchTree<E> {
node.left.segment = iter.value();
}
node = node.left;

} else if (val < 0) {
// right
if (!node.right) {
Expand Down
2 changes: 1 addition & 1 deletion src/github/pullRequestManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1503,7 +1503,7 @@ export class PullRequestManager {
const author = matchingCommits[0].author;
// There is not necessarily a GitHub account associated with the commit.
if (author !== null) {
if(pullRequest.githubRepository.isGitHubDotCom) {
if (pullRequest.githubRepository.isGitHubDotCom) {
commitEvent.author.avatarUrl = author.avatar_url;
}

Expand Down
2 changes: 1 addition & 1 deletion src/github/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ function parseAuthor(author: {login: string, url: string, avatarUrl: string}, gi
login: author.login,
url: author.url,
avatarUrl: githubRepository.isGitHubDotCom ? author.avatarUrl : undefined
}
};
}

export function parseGraphQLPullRequest(pullRequest: GraphQL.PullRequestResponse, githubRepository: GitHubRepository): PullRequest {
Expand Down
2 changes: 1 addition & 1 deletion tslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
"always"
],
"triple-equals": true,
"whitespace": true
"whitespace": [true, "check-branch"]
}
}
17 changes: 1 addition & 16 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,14 +655,6 @@ aws4@^1.8.0:
resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f"
integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ==

axios@^0.18.0:
version "0.18.0"
resolved "https://registry.yarnpkg.com/axios/-/axios-0.18.0.tgz#32d53e4851efdc0a11993b6cd000789d70c05102"
integrity sha1-MtU+SFHv3AoRmTts0AB4nXDAUQI=
dependencies:
follow-redirects "^1.3.0"
is-buffer "^1.1.5"

babel-code-frame@^6.22.0, babel-code-frame@^6.26.0:
version "6.26.0"
resolved "https://registry.yarnpkg.com/babel-code-frame/-/babel-code-frame-6.26.0.tgz#63fd43f7dc1e3bb7ce35947db8fe369a3f58c74b"
Expand Down Expand Up @@ -1422,7 +1414,7 @@ debounce@^1.2.0:
resolved "https://registry.yarnpkg.com/debounce/-/debounce-1.2.0.tgz#44a540abc0ea9943018dc0eaa95cce87f65cd131"
integrity sha512-mYtLl1xfZLi1m4RtQYlZgJUNQjl4ZxVnHzIR8nLLgi4q1YT8o/WM+MK/f8yfcc9s5Ir5zRaPZyZU6xs1Syoocg==

debug@3.1.0, debug@=3.1.0, debug@^3.1.0:
debug@3.1.0, debug@^3.1.0:
version "3.1.0"
resolved "https://registry.yarnpkg.com/debug/-/debug-3.1.0.tgz#5bb5a0672628b64149566ba16819e61518c67261"
integrity sha512-OX8XqP7/1a9cqkxYw2yXss15f26NKWBpDXQd0/uK/KPqdQhxbPa994hnzjcE2VqQpDslf55723cKPUOGSmMY3g==
Expand Down Expand Up @@ -1938,13 +1930,6 @@ flush-write-stream@^1.0.0, flush-write-stream@^1.0.2:
inherits "^2.0.1"
readable-stream "^2.0.4"

follow-redirects@^1.3.0:
version "1.5.8"
resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.5.8.tgz#1dbfe13e45ad969f813e86c00e5296f525c885a1"
integrity sha512-sy1mXPmv7kLAMKW/8XofG7o9T+6gAjzdZK4AJF6ryqQYUa/hnzgiypoeUecZ53x7XiqKNEpNqLtS97MshW2nxg==
dependencies:
debug "=3.1.0"

for-in@^1.0.1, for-in@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/for-in/-/for-in-1.0.2.tgz#81068d295a8142ec0ac726c6e2200c30fb6d5e80"
Expand Down