Skip to content

Fix Share GitHub Permalink as Markdown to use filename instead of cursor text #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 3 commits into from
Dec 18, 2025
Merged

Fix Share GitHub Permalink as Markdown to use filename instead of cursor text #8251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f93c8dc
Initial plan
Copilot Dec 9, 2025
7444e5c
Initial plan for fixing permalink markdown link text
Copilot Dec 9, 2025
ddeebef
Fix Share GitHub Permalink as Markdown to always use filename
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/@types/vscode.proposed.chatParticipantAdditions.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ declare module 'vscode' {
isComplete?: boolean;
toolSpecificData?: ChatTerminalToolInvocationData;
fromSubAgent?: boolean;
presentation?: 'hidden' | 'hiddenAfterComplete' | undefined;

constructor(toolName: string, toolCallId: string, isError?: boolean);
}
Expand Down
22 changes: 1 addition & 21 deletions src/issues/shareProviders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,27 +218,7 @@ export class GitHubPermalinkAsMarkdownShareProvider extends GitHubPermalinkShare
}

private async getMarkdownLinkText(item: vscode.ShareableItem): Promise<string | undefined> {
const fileName = pathLib.basename(item.resourceUri.path);

if (item.selection) {
const document = await vscode.workspace.openTextDocument(item.resourceUri);

const editorSelection = item.selection.start === item.selection.end
? item.selection
: new vscode.Range(item.selection.start, new vscode.Position(item.selection.start.line + 1, 0));

const selectedText = document.getText(editorSelection);
if (selectedText) {
return selectedText;
}

const wordRange = document.getWordRangeAtPosition(item.selection.start);
if (wordRange) {
return document.getText(wordRange);
}
}

return fileName;
return pathLib.basename(item.resourceUri.path);
}
}

Expand Down