no config debug: Fix error when multiple vscode windows are open#918
no config debug: Fix error when multiple vscode windows are open#918Zentrik wants to merge 9 commits intomicrosoft:mainfrom
Conversation
Should fix microsoft#916, but getting this installed locally seemed sufficiently complicated that I gave up. Fix is: 1. Only watch a specific endpoint file 2. Make sure this endpoint file is unique (I imagine the workspace file path can be non unique across vscode windows)
|
Whoops, didn't meant to close this. @Zentrik it looks like this is causing a bunch of test failures. |
I guess this is what I get for trusting AI at midnight.
The error seems to be that `base` is `c:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.noConfigDebugAdapterEndpoints` but `noConfigEndpointDir` is `C:\Users\RUNNER~1\AppData\Local\Temp\.noConfigDebugAdapterEndpoints` (the C is capitalised). Getting the fsPath of the URI should normalise the path the same as `base`.
Sorry about that, thanks for reviewing. I think it should be fixed now, o/w will have to wait till tmrw and I'll boot into windows to debug further. |
|
Including the workspace part of the hash seems unnecessary given the inclusion of the |
Should fix #916,
but getting this installed locally seemed sufficiently complicated that I gave up. I figured out the nox stuff, I tested with two windows and this worked.Fix is: