Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@jonathanwangg
Copy link
Contributor

Description:

Adding Adafruit to the ThirdPartyNotices.txt file since we referenced their CircuitPython library when we were mocking our API.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Limitations:

Will most likely have merge conflicts once the other PRs get merged since those ones also update the ThirdPartyNotices.txt file.

Testing:

None

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@Christellah Christellah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merge conflicts fix, good to go 🚀

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy change man

@LukeSlev
Copy link
Member

@jonathanwangg conflicts tho

@jonathanwangg jonathanwangg merged commit 0d6efe4 into dev Aug 22, 2019
@jonathanwangg jonathanwangg deleted the users/t-jowang/attribute-adafruit branch August 23, 2019 01:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants