Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@FMounz
Copy link
Contributor

@FMounz FMounz commented Aug 20, 2019

Description:

This PR add localization to the React side using react-intl module.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

This PR is only about localization since we don't provide translation s in other languages

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@FMounz FMounz closed this Aug 20, 2019
@FMounz FMounz reopened this Aug 20, 2019
Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukeSlev
Copy link
Member

@FMounz conflicts

@FMounz FMounz merged commit 79f0473 into dev Aug 21, 2019
@jonathanwangg jonathanwangg deleted the users/t-famoun/localize-react branch August 26, 2019 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants