Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Conversation

@FMounz
Copy link
Contributor

@FMounz FMounz commented Aug 21, 2019

Description:

This PR updates the different documentation files.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Testing:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just some typos and grammar suggestions.

@jonathanwangg
Copy link
Contributor

Would it also be possible to move "Serial Monitor" to features that our extension supports instead of "Doesn't support"?

FMounz and others added 9 commits August 21, 2019 10:54
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
FMounz and others added 3 commits August 21, 2019 11:45
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Co-Authored-By: Jonathan Wang <jonathanwangg@gmail.com>
Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update to the documentation!

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FMounz FMounz merged commit cc1b0db into dev Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants